[jira] [Updated] (KAFKA-1147) Consumer socket timeout should be greater than fetch max wait

[ https://issues.apache.org/jira/browse/KAFKA-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1147: - Affects Version/s: 0.8.1 0.8 > Consumer socket timeout should be greater t

[jira] [Updated] (KAFKA-1153) typos in documentation

[ https://issues.apache.org/jira/browse/KAFKA-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1153: - Assignee: Joe Stein > typos in documentation > -- > > Key: KA

[jira] [Closed] (KAFKA-1153) typos in documentation

[ https://issues.apache.org/jira/browse/KAFKA-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede closed KAFKA-1153. > typos in documentation > -- > > Key: KAFKA-1153 >

[jira] [Updated] (KAFKA-1151) The Hadoop consumer API doc is not referencing the contrib consumer

[ https://issues.apache.org/jira/browse/KAFKA-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1151: - Status: Patch Available (was: Open) > The Hadoop consumer API doc is not referencing the contrib consume

[jira] [Updated] (KAFKA-1151) The Hadoop consumer API doc is not referencing the contrib consumer

[ https://issues.apache.org/jira/browse/KAFKA-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1151: - Attachment: KAFKA-1151.patch I gave a stab at what I think would preserve the spirit of the apache contri

Re: [VOTE] Apache Kafka Release 0.8.0 - Candidate 5

Seems like most people are verifying the src, so I'll pick on the binaries and Maven stuff ;) A few problems I see: There are some vestigial Git files in the src download: an empty .git and .gitignore In the source download, I see the SBT license in LICENSE which seems correct (since we dis

[jira] [Commented] (KAFKA-1154) replicas may not have consistent data after becoming follower

[ https://issues.apache.org/jira/browse/KAFKA-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13836683#comment-13836683 ] Neha Narkhede commented on KAFKA-1154: -- We used to do this, looks like this was a reg

Re: Review Request 15938: replicas may not have consistent data after becoming follower

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15938/#review29586 --- core/src/main/scala/kafka/server/KafkaApis.scala

Re: [VOTE] Apache Kafka Release 0.8.0 - Candidate 5

Talking about binary release, do we really need to include bin/run-rat.sh? As far as I understand it is only used to bring licenses to the scene and quite redundant for already baked release. Next, I not quite sure, but probably it makes sense to drop libs/scala-compiler.jar -- kafka do not perfor

Re: Review Request 15901: Patch for KAFKA-1152

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15901/#review29588 --- core/src/main/scala/kafka/server/ReplicaManager.scala

[jira] [Commented] (KAFKA-1036) Unable to rename replication offset checkpoint in windows

[ https://issues.apache.org/jira/browse/KAFKA-1036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13836698#comment-13836698 ] Neha Narkhede commented on KAFKA-1036: -- [~jantxu] Are you sure this is required? If w

Re: [VOTE] Apache Kafka Release 0.8.0 - Candidate 5

I think we should maintain a wiki describing the release process in detail, so we save the turnaround time on a release. We can have a VOTE thread to agree on the release guidelines and follow it. Having said that, it is worth having the correct .pom file at the very least, since the release is no

Re: [VOTE] Apache Kafka Release 0.8.0 - Candidate 5

General future thought comment first: lets be careful please to raising issues as show stoppers that have been there previously (especially if greater than one version previous release back also has the problem) and can get fixed in a subsequent release and is only now more pressing because we know

Re: Review Request 15659: Incorporate Joel/Jun's comments, MM system test passed, rebased

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15659/#review29593 --- core/src/main/scala/kafka/consumer/ZookeeperTopicEventWatcher.scala

[jira] [Updated] (KAFKA-1133) LICENSE and NOTICE files need to get into META-INF when jars are built before they're signed for publishing to maven

[ https://issues.apache.org/jira/browse/KAFKA-1133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1133: - Assignee: Joe Stein > LICENSE and NOTICE files need to get into META-INF when jars are built >

Re: Review Request 15901: Patch for KAFKA-1152

> On Dec. 2, 2013, 5:06 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/server/ReplicaManager.scala, line 358 > > > > > > the check should probably be leaderId >= 0. The "leaders" in the > > LeaderAndIsrReque

Re: [VOTE] Apache Kafka Release 0.8.0 - Candidate 5

Neha, as far as the release process is this what you had in mind https://cwiki.apache.org/confluence/display/KAFKA/Release+Process or different content or more of something or such? Per the POM, I was able to use the artifacts from the maven repository without having to-do anything more than just

Re: Review Request 15711: Patch for KAFKA-930

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15711/#review29597 --- core/src/main/scala/kafka/controller/KafkaController.scala

Re: [VOTE] Apache Kafka Release 0.8.0 - Candidate 5

Inline: On 12/2/13 11:59 AM, Joe Stein wrote: General future thought comment first: lets be careful please to raising issues as show stoppers that have been there previously (especially if greater than one version previous release back also has the problem) and can get fixed in a subsequent rele

[jira] [Created] (KAFKA-1155) Kafka server can miss zookeeper watches during long zkclient callbacks

Neha Narkhede created KAFKA-1155: Summary: Kafka server can miss zookeeper watches during long zkclient callbacks Key: KAFKA-1155 URL: https://issues.apache.org/jira/browse/KAFKA-1155 Project: Kafka

Re: Review Request 15711: Patch for KAFKA-930

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15711/#review29606 --- core/src/main/scala/kafka/server/KafkaConfig.scala

Re: [VOTE] Apache Kafka Release 0.8.0 - Candidate 5

Thanks for creating https://cwiki.apache.org/confluence/display/KAFKA/Release+Process. That was what I was looking for. It will be worth updating it right after the 0.8 release and keep it updated as we change the guidelines. Thanks again! -Neha On Mon, Dec 2, 2013 at 10:19 AM, David Arthur wro

[jira] [Updated] (KAFKA-1074) Reassign partitions should delete the old replicas from disk

[ https://issues.apache.org/jira/browse/KAFKA-1074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1074: - Assignee: Jun Rao > Reassign partitions should delete the old replicas from disk > --

Re: [VOTE] Apache Kafka Release 0.8.0 - Candidate 5

Joe, another thing I noticed in the staging repo: The POM for 2.8.2, 2.9.1, 2.9.2, and 2.10 include scala-compiler and some other stuff that is not included in 2.8.0 2.8.0 https://repository.apache.org/content/groups/staging/org/apache/kafka/kafka_2.8.0/0.8.0/kafka_2.8.0-0.8.0.pom 2.8.2 http

Re: Review Request 15938: replicas may not have consistent data after becoming follower

> On Dec. 2, 2013, 4:55 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/server/ReplicaManager.scala, line 329 > > > > > > Do we still need this "TODO: the above may need to be fixed later" ? Yes, this can be

Re: Review Request 15938: replicas may not have consistent data after becoming follower

> On Dec. 2, 2013, 4:55 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/server/KafkaApis.scala, line 396 > > > > > > We had added the ability for a special consumer to read the replica log > > for troubleshoo

[jira] [Assigned] (KAFKA-1050) Support for "no data loss" mode

[ https://issues.apache.org/jira/browse/KAFKA-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede reassigned KAFKA-1050: Assignee: Neha Narkhede > Support for "no data loss" mode > ---

Re: Review Request 15674: Reassign partitions should delete the old replicas from disk

> On Nov. 19, 2013, 6:40 p.m., Jay Kreps wrote: > > What happens if I am doing a read or write concurrently with a delete? > > > > Would it be simpler just to have the delete log work like the segment > > delete where rather than trying to lock we remove it from the segment list > > and then j

[jira] Subscription: outstanding kafka patches

Issue Subscription Filter: outstanding kafka patches (75 issues) The list of outstanding kafka patches Subscriber: kafka-mailing-list Key Summary KAFKA-1154 replicas may not have consistent data after becoming follower https://issues.apache.org/jira/browse/KAFKA-1154 KAFKA-115

Re: Review Request 15938: replicas may not have consistent data after becoming follower

> On Dec. 2, 2013, 4:55 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/server/KafkaApis.scala, line 396 > > > > > > We had added the ability for a special consumer to read the replica log > > for troubleshoo

Re: Review Request 15938: replicas may not have consistent data after becoming follower

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15938/#review29622 --- Ship it! Ship It! - Neha Narkhede On Dec. 1, 2013, 11:33 p.m., J

[jira] [Resolved] (KAFKA-1154) replicas may not have consistent data after becoming follower

[ https://issues.apache.org/jira/browse/KAFKA-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-1154. Resolution: Fixed Thanks for the review. Committed to trunk after addressing the minor review comments. >

[jira] [Created] (KAFKA-1156) Improve reassignment tool to output the existing assignment to facilitate rollbacks

Neha Narkhede created KAFKA-1156: Summary: Improve reassignment tool to output the existing assignment to facilitate rollbacks Key: KAFKA-1156 URL: https://issues.apache.org/jira/browse/KAFKA-1156 Pro

[jira] [Created] (KAFKA-1157) Clean up Per-topic Configuration from Kafka properties

Guozhang Wang created KAFKA-1157: Summary: Clean up Per-topic Configuration from Kafka properties Key: KAFKA-1157 URL: https://issues.apache.org/jira/browse/KAFKA-1157 Project: Kafka Issue Ty

Review Request 15950: Patch for KAFKA-1157

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15950/ --- Review request for kafka. Bugs: KAFKA-1157 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-1157) Clean up Per-topic Configuration from Kafka properties

[ https://issues.apache.org/jira/browse/KAFKA-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1157: - Attachment: KAFKA-1157.patch > Clean up Per-topic Configuration from Kafka properties > -

[jira] [Commented] (KAFKA-1157) Clean up Per-topic Configuration from Kafka properties

[ https://issues.apache.org/jira/browse/KAFKA-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13837131#comment-13837131 ] Guozhang Wang commented on KAFKA-1157: -- Created reviewboard https://reviews.apache.or

Review Request 15953: Patch for KAFKA-1134

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15953/ --- Review request for kafka. Bugs: KAFKA-1134 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-1134) onControllerFailover function should be synchronized with other functions

[ https://issues.apache.org/jira/browse/KAFKA-1134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1134: - Attachment: KAFKA-1134.patch > onControllerFailover function should be synchronized with other fu

[jira] [Commented] (KAFKA-1134) onControllerFailover function should be synchronized with other functions

[ https://issues.apache.org/jira/browse/KAFKA-1134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13837172#comment-13837172 ] Guozhang Wang commented on KAFKA-1134: -- Created reviewboard https://reviews.apache.or

Re: Review Request 15953: Patch for KAFKA-1134

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15953/#review29636 --- core/src/main/scala/kafka/controller/KafkaController.scala

Re: Review Request 15953: Patch for KAFKA-1134

> On Dec. 3, 2013, 1:30 a.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/controller/KafkaController.scala, line 235 > > > > > > it seems that onControllerFailover is already protected by the > > controllerLock

[jira] [Resolved] (KAFKA-1157) Clean up Per-topic Configuration from Kafka properties

[ https://issues.apache.org/jira/browse/KAFKA-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-1157. Resolution: Fixed Fix Version/s: 0.8.1 Thanks for the patch. +1 and committed to trunk. > Clean up

Re: [VOTE] Apache Kafka Release 0.8.0 - Candidate 5

The release voting is based on lazy majority ( https://cwiki.apache.org/confluence/display/KAFKA/Bylaws#Bylaws-Voting). So a -1 doesn't kill the release. The question is whether those issues are really show stoppers. Thanks, Jun On Mon, Dec 2, 2013 at 10:19 AM, David Arthur wrote: > Inline: