[ 
https://issues.apache.org/jira/browse/KAFKA-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13836683#comment-13836683
 ] 

Neha Narkhede commented on KAFKA-1154:
--------------------------------------

We used to do this, looks like this was a regression introduced in KAFKA-1001. 

1. ReplicaManager
Do we still need this "TODO: the above may need to be fixed later" ?

2. We had added the ability for a special consumer to read the replica log for 
troubleshooting. This patch takes that convenience away. We should probably 
look for another way to prevent the replica verification tool from giving false 
negatives. Can it use a different consumer id?


> replicas may not have consistent data after becoming follower
> -------------------------------------------------------------
>
>                 Key: KAFKA-1154
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1154
>             Project: Kafka
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 0.8.1
>            Reporter: Jun Rao
>            Assignee: Jun Rao
>             Fix For: 0.8.1
>
>         Attachments: KAFKA-1154.patch
>
>
> This is an issued introduced in KAFKA-1001. The issue is that in 
> ReplicaManager.makeFollowers(), we truncate the log before marking the 
> replica as the follower. New messages from the producer can still be added to 
> the log after the log is truncated, but before the replica is marked as the 
> follower. Those newly produced messages can actually be committed, which 
> implies those truncated messages are also committed. However, the new leader 
> is not guaranteed to have those truncated messages.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to