KAFKA-1092 patch for review

Hi dev list, As suggested on the website, this is a friendly nag. I submitted a patch for a config change. Can someone please take a look? Here's the message I posted to the users list: OK. I've submitted a patch along with unit tests. This change is backward compatible with two new optional

[jira] [Created] (KAFKA-1109) Need to fix GC log configuration code, not able to override KAFKA_GC_LOG_OPTS

Viktor Kolodrevskiy created KAFKA-1109: -- Summary: Need to fix GC log configuration code, not able to override KAFKA_GC_LOG_OPTS Key: KAFKA-1109 URL: https://issues.apache.org/jira/browse/KAFKA-1109

Re: Review Request 14865: Patch for KAFKA-1097

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14865/#review27787 --- Thanks for the patch. Could you rebase? core/src/main/scala/kafka/

Re: KAFKA-1092 patch for review

Reviewed. Thanks, Jun On Wed, Oct 30, 2013 at 9:45 AM, Roger Hoover wrote: > Hi dev list, > > As suggested on the website, this is a friendly nag. I submitted a patch > for a config change. Can someone please take a look? > > Here's the message I posted to the users list: > > OK. I've submi

[jira] [Commented] (KAFKA-1092) Add server config parameter to separate bind address and ZK hostname

[ https://issues.apache.org/jira/browse/KAFKA-1092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13809377#comment-13809377 ] Jun Rao commented on KAFKA-1092: Thanks for the patch. 1. Could you change the property

Re: KAFKA-1092 patch for review

Thanks! I'll work on incorporating your feedback. On Wed, Oct 30, 2013 at 10:34 AM, Jun Rao wrote: > Reviewed. > > Thanks, > > Jun > > > On Wed, Oct 30, 2013 at 9:45 AM, Roger Hoover >wrote: > > > Hi dev list, > > > > As suggested on the website, this is a friendly nag. I submitted a patch >

[jira] [Created] (KAFKA-1110) Unable to produce messages with snappy/gzip compression

Arup Malakar created KAFKA-1110: --- Summary: Unable to produce messages with snappy/gzip compression Key: KAFKA-1110 URL: https://issues.apache.org/jira/browse/KAFKA-1110 Project: Kafka Issue Typ

[jira] [Updated] (KAFKA-1110) Unable to produce messages with snappy/gzip compression

[ https://issues.apache.org/jira/browse/KAFKA-1110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arup Malakar updated KAFKA-1110: Attachment: kafka_producer_snappy_pkt_63.pcapng sarama_producer_snappy_pkt_1.pcapng

[jira] [Commented] (KAFKA-1110) Unable to produce messages with snappy/gzip compression

[ https://issues.apache.org/jira/browse/KAFKA-1110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13809464#comment-13809464 ] Evan Huus commented on KAFKA-1110: -- I am the primary author of the golang library and the

[jira] [Updated] (KAFKA-1110) Unable to produce messages with snappy/gzip compression

[ https://issues.apache.org/jira/browse/KAFKA-1110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arup Malakar updated KAFKA-1110: Description: Sarama[1] (A golang kafka library: https://github.com/Shopify/sarama) is following th

[jira] [Updated] (KAFKA-1092) Add server config parameter to separate bind address and ZK hostname

[ https://issues.apache.org/jira/browse/KAFKA-1092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Hoover updated KAFKA-1092: Status: Open (was: Patch Available) > Add server config parameter to separate bind address and ZK

[jira] [Updated] (KAFKA-1092) Add server config parameter to separate bind address and ZK hostname

[ https://issues.apache.org/jira/browse/KAFKA-1092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Hoover updated KAFKA-1092: Status: Patch Available (was: Open) > Add server config parameter to separate bind address and ZK

[jira] [Updated] (KAFKA-1092) Add server config parameter to separate bind address and ZK hostname

[ https://issues.apache.org/jira/browse/KAFKA-1092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Hoover updated KAFKA-1092: Attachment: KAFKA-1092.patch Updated parameter names to "advertised.host.name" and "advertised.port

[jira] [Commented] (KAFKA-1092) Add server config parameter to separate bind address and ZK hostname

[ https://issues.apache.org/jira/browse/KAFKA-1092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13809668#comment-13809668 ] Roger Hoover commented on KAFKA-1092: - The reason the kafka.producer.ProducerTest was

[jira] [Comment Edited] (KAFKA-1092) Add server config parameter to separate bind address and ZK hostname

[ https://issues.apache.org/jira/browse/KAFKA-1092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13809668#comment-13809668 ] Roger Hoover edited comment on KAFKA-1092 at 10/30/13 9:52 PM: -

Re: KAFKA-1092 patch for review

Jun, I've fixed the two things you mentioned. All the tests now pass. Cheers, Roger On Wed, Oct 30, 2013 at 10:53 AM, Roger Hoover wrote: > Thanks! I'll work on incorporating your feedback. > > > On Wed, Oct 30, 2013 at 10:34 AM, Jun Rao wrote: > >> Reviewed. >> >> Thanks, >> >> Jun >> >> >

Re: Review Request 14898: Small bug fix

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14898/#review27837 --- Ship it! Ship It! - Neha Narkhede On Oct. 29, 2013, 6:12 p.m., G

[jira] [Resolved] (KAFKA-1060) Break-down sendTime into responseQueueTime and the real sendTime

[ https://issues.apache.org/jira/browse/KAFKA-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede resolved KAFKA-1060. -- Resolution: Fixed Pushed to trunk > Break-down sendTime into responseQueueTime and the real se

[jira] [Closed] (KAFKA-1060) Break-down sendTime into responseQueueTime and the real sendTime

[ https://issues.apache.org/jira/browse/KAFKA-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede closed KAFKA-1060. > Break-down sendTime into responseQueueTime and the real sendTime > --

[jira] [Updated] (KAFKA-1092) Add server config parameter to separate bind address and ZK hostname

[ https://issues.apache.org/jira/browse/KAFKA-1092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1092: --- Resolution: Fixed Fix Version/s: 0.8.1 Assignee: Roger Hoover Status: Resolved (wa

[jira] [Commented] (KAFKA-1097) Race condition while reassigning low throughput partition leads to incorrect ISR information in zookeeper

[ https://issues.apache.org/jira/browse/KAFKA-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13809909#comment-13809909 ] Neha Narkhede commented on KAFKA-1097: -- Updated reviewboard https://reviews.apache.or

Re: Review Request 14865: Patch for KAFKA-1097

> On Oct. 30, 2013, 5:12 p.m., Jun Rao wrote: > > core/src/main/scala/kafka/controller/KafkaController.scala, lines 397-398 > > > > > > Should we name this addedReplicas? To me, new and old replicas mean the > > set o

[jira] [Updated] (KAFKA-1097) Race condition while reassigning low throughput partition leads to incorrect ISR information in zookeeper

[ https://issues.apache.org/jira/browse/KAFKA-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1097: - Attachment: KAFKA-1097_2013-10-30_21:46:00.patch > Race condition while reassigning low throughpu

Re: Review Request 14865: Patch for KAFKA-1097

> On Oct. 29, 2013, 9:12 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/cluster/Partition.scala, line 163 > > > > > > Also add "// add replicas that are new" Done > On Oct. 29, 2013, 9:12 p.m., Guozhang Wa

Re: Review Request 14865: Patch for KAFKA-1097

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14865/ --- (Updated Oct. 31, 2013, 4:46 a.m.) Review request for kafka. Bugs: KAFKA-1097