Reviewed. Thanks,
Jun On Wed, Oct 30, 2013 at 9:45 AM, Roger Hoover <roger.hoo...@gmail.com>wrote: > Hi dev list, > > As suggested on the website, this is a friendly nag. I submitted a patch > for a config change. Can someone please take a look? > > Here's the message I posted to the users list: > > OK. I've submitted a patch along with unit tests. This change is backward > compatible with two new optional parameters called advertise.host.name and > advertise.port. The reason I called them that instead of zkHost.name and > zkHost.port is that the zkHost.* names sound like they represent the host > and port of a ZooKeeper server rather than the host and port info of the > broker that gets published to ZK. > > # Hostname the broker will advertise to producers and consumers. If not > set, it uses the > # value for "host.name" if configured. Otherwise, it will use the value > returned from > # java.net.InetAddress.getCanonicalHostName(). > #advertise.host.name=<hostname routable by clients> > > # The port to publish to ZooKeeper for clients to use. If this is not set, > # it will publish the same port that the broker binds to. > #advertise.port=<port accessible by clients> > > https://issues.apache.org/jira/browse/KAFKA-1092 > > Please take a look and let me know if anything else is needed. > > Cheers, > > Roger >
