Re: Review Request 33614: Patch for KAFKA-2132

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33614/ --- (Updated June 30, 2015, 7:07 p.m.) Review request for kafka. Bugs: KAFKA-2132

Re: Review Request 33614: Patch for KAFKA-2132

> On June 30, 2015, 5:12 p.m., Jun Rao wrote: > > Thanks for the patch. Just a few minor comments below. Thanks Jun for the review. > On June 30, 2015, 5:12 p.m., Jun Rao wrote: > > build.gradle, lines 389-391 > > > > >

Re: Review Request 33614: Patch for KAFKA-2132

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33614/#review89919 --- Thanks for the patch. Just a few minor comments below. build.gradl

Re: Review Request 33614: Patch for KAFKA-2132

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33614/ --- (Updated June 24, 2015, 5:25 p.m.) Review request for kafka. Bugs: KAFKA-2132

Re: Review Request 33614: Patch for KAFKA-2132

> On June 16, 2015, 1:31 a.m., Jun Rao wrote: > > Thanks for the patch. There seems to be a compilation error. > > > > :log4j-appender:compileTestJava > > /Users/junrao/intellij/kafka/log4j-appender/src/test/java/org/apache/kafka/log4jappender/MockKafkaLog4jAppender.java:27: > > cannot find sym

Re: Review Request 33614: Patch for KAFKA-2132

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33614/ --- (Updated June 24, 2015, 5:20 p.m.) Review request for kafka. Bugs: KAFKA-2132

Re: Review Request 33614: Patch for KAFKA-2132

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33614/#review88015 --- Thanks for the patch. There seems to be a compilation error. :log4j

Re: Review Request 33614: Patch for KAFKA-2132

> On June 11, 2015, 10:15 p.m., Aditya Auradkar wrote: > > log4j-appender/src/main/java/org/apache/kafka/log4jappender/KafkaLog4jAppender.java, > > line 135 > > > > > > perhaps wrap this inside an isDebugEnabled check

Re: Review Request 33614: Patch for KAFKA-2132

> On June 12, 2015, 2:03 a.m., Jun Rao wrote: > > Thanks for the patch. A few comments below. Thanks for the review Jun. Addressed your comments. > On June 12, 2015, 2:03 a.m., Jun Rao wrote: > > log4j-appender/src/main/java/org/apache/kafka/log4jappender/KafkaLog4jAppender.java, > > lines 12

Re: Review Request 33614: Patch for KAFKA-2132

> On June 11, 2015, 10:15 p.m., Aditya Auradkar wrote: > > Hey Ashish, > > > > I've left a few minor comments. Thanks! Thanks for the review Aditya. Addressed your comments. > On June 11, 2015, 10:15 p.m., Aditya Auradkar wrote: > > log4j-appender/src/main/java/org/apache/kafka/log4jappender/

Re: Review Request 33614: Patch for KAFKA-2132

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33614/ --- (Updated June 14, 2015, 4:19 a.m.) Review request for kafka. Bugs: KAFKA-2132

Re: Review Request 33614: Patch for KAFKA-2132

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33614/#review87670 --- Thanks for the patch. A few comments below. build.gradle

Re: Review Request 33614: Patch for KAFKA-2132

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33614/#review87638 --- Hey Ashish, I've left a few minor comments. Thanks! log4j-appende

Re: Review Request 33614: Patch for KAFKA-2132

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33614/#review82231 --- Ship it! Ship It! - Gwen Shapira On April 30, 2015, 10:53 p.m.,

Re: Review Request 33614: Patch for KAFKA-2132

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33614/ --- (Updated April 30, 2015, 10:53 p.m.) Review request for kafka. Bugs: KAFKA-21

Re: Review Request 33614: Patch for KAFKA-2132

> On April 29, 2015, 11:46 p.m., Gwen Shapira wrote: > > Overall, looks good. > > I had a bunch of nits :) Thanks for the review Gwen! > On April 29, 2015, 11:46 p.m., Gwen Shapira wrote: > > build.gradle, line 402 > >

Re: Review Request 33614: Patch for KAFKA-2132

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33614/ --- (Updated April 30, 2015, 7:22 p.m.) Review request for kafka. Bugs: KAFKA-213

Re: Review Request 33614: Patch for KAFKA-2132

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33614/#review82056 --- Overall, looks good. I had a bunch of nits :) build.gradle

Re: Review Request 33614: Patch for KAFKA-2132

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33614/ --- (Updated April 28, 2015, 9:38 p.m.) Review request for kafka. Bugs: KAFKA-213

Re: Review Request 33614: Patch for KAFKA-2132

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33614/ --- (Updated April 28, 2015, 3 a.m.) Review request for kafka. Bugs: KAFKA-2132

Re: Review Request 33614: Patch for KAFKA-2132

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33614/ --- (Updated April 28, 2015, 2:58 a.m.) Review request for kafka. Bugs: KAFKA-213

Review Request 33614: Patch for KAFKA-2132

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33614/ --- Review request for kafka. Bugs: KAFKA-2132 https://issues.apache.org/jira/b