> On June 30, 2015, 5:12 p.m., Jun Rao wrote: > > Thanks for the patch. Just a few minor comments below.
Thanks Jun for the review. > On June 30, 2015, 5:12 p.m., Jun Rao wrote: > > build.gradle, lines 389-391 > > <https://reviews.apache.org/r/33614/diff/9/?file=991359#file991359line389> > > > > Could you explain a bit why we need this? This is required as log4j-appender tests uses the MockSerializer, which is in org.apache.kafka.test. > On June 30, 2015, 5:12 p.m., Jun Rao wrote: > > build.gradle, lines 408-409 > > <https://reviews.apache.org/r/33614/diff/9/?file=991359#file991359line408> > > > > Since we already have a compile time dependency on these, we don't need > > to add them as test dependency. Got rid of slf4jlog4j. However, to be able to reuse MockSerializer only during testCompile time, dependency on clients' 'archives' config is required. > On June 30, 2015, 5:12 p.m., Jun Rao wrote: > > build.gradle, lines 412-415 > > <https://reviews.apache.org/r/33614/diff/9/?file=991359#file991359line412> > > > > Do we need to publish a test jar for kafka-log4j-appender? Not necessarily. Removed. - Ashish ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33614/#review89919 ----------------------------------------------------------- On June 24, 2015, 5:25 p.m., Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33614/ > ----------------------------------------------------------- > > (Updated June 24, 2015, 5:25 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2132 > https://issues.apache.org/jira/browse/KAFKA-2132 > > > Repository: kafka > > > Description > ------- > > KAFKA-2132: Move Log4J appender to clients module > > > Diffs > ----- > > build.gradle 30d1cf2f1ff9ed3f86a060da8099bb0774b4cf91 > checkstyle/import-control.xml f2e6cec267e67ce8e261341e373718e14a8e8e03 > core/src/main/scala/kafka/producer/KafkaLog4jAppender.scala > 5d36a019e3dbfb93737a9cd23404dcd1c5d836d1 > core/src/test/scala/unit/kafka/log4j/KafkaLog4jAppenderTest.scala > 41366a14590d318fced0e83d6921d8035fa882da > > log4j-appender/src/main/java/org/apache/kafka/log4jappender/KafkaLog4jAppender.java > PRE-CREATION > > log4j-appender/src/test/java/org/apache/kafka/log4jappender/KafkaLog4jAppenderTest.java > PRE-CREATION > > log4j-appender/src/test/java/org/apache/kafka/log4jappender/MockKafkaLog4jAppender.java > PRE-CREATION > settings.gradle 83f764e6a4a15a5fdba232dce74a369870f26b45 > > Diff: https://reviews.apache.org/r/33614/diff/ > > > Testing > ------- > > > Thanks, > > Ashish Singh > >
