> On June 12, 2015, 2:03 a.m., Jun Rao wrote: > > Thanks for the patch. A few comments below.
Thanks for the review Jun. Addressed your comments. > On June 12, 2015, 2:03 a.m., Jun Rao wrote: > > log4j-appender/src/main/java/org/apache/kafka/log4jappender/KafkaLog4jAppender.java, > > lines 121-122 > > <https://reviews.apache.org/r/33614/diff/6/?file=946526#file946526line121> > > > > Would it be better to use the built-in StringSerializer? Gwen also had the some comment :). Honestly, I had the same question. However, I did not want to change the original behaviour. I doubt using StringSerializer will change the behaviour, but having byte serializer is helpful for testing as it can be easily overridden by MockProducer. If we really have to use StringSerializer, I can create a wrapper on top of current MockProducer to support String values. > On June 12, 2015, 2:03 a.m., Jun Rao wrote: > > build.gradle, line 219 > > <https://reviews.apache.org/r/33614/diff/6/?file=946522#file946522line219> > > > > Could you check if this is needed? I think a compile dependency implies > > a testCompile dependency. Its not :). Removed. - Ashish ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33614/#review87670 ----------------------------------------------------------- On June 14, 2015, 4:19 a.m., Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33614/ > ----------------------------------------------------------- > > (Updated June 14, 2015, 4:19 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2132 > https://issues.apache.org/jira/browse/KAFKA-2132 > > > Repository: kafka > > > Description > ------- > > KAFKA-2132: Move Log4J appender to clients module > > > Diffs > ----- > > build.gradle 30d1cf2f1ff9ed3f86a060da8099bb0774b4cf91 > checkstyle/import-control.xml f2e6cec267e67ce8e261341e373718e14a8e8e03 > core/src/main/scala/kafka/producer/KafkaLog4jAppender.scala > 5d36a019e3dbfb93737a9cd23404dcd1c5d836d1 > core/src/test/scala/unit/kafka/log4j/KafkaLog4jAppenderTest.scala > 41366a14590d318fced0e83d6921d8035fa882da > > log4j-appender/src/main/java/org/apache/kafka/log4jappender/KafkaLog4jAppender.java > PRE-CREATION > > log4j-appender/src/test/java/org/apache/kafka/log4jappender/KafkaLog4jAppenderTest.java > PRE-CREATION > > log4j-appender/src/test/java/org/apache/kafka/log4jappender/MockKafkaLog4jAppender.java > PRE-CREATION > settings.gradle 83f764e6a4a15a5fdba232dce74a369870f26b45 > > Diff: https://reviews.apache.org/r/33614/diff/ > > > Testing > ------- > > > Thanks, > > Ashish Singh > >
