----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33614/#review87670 -----------------------------------------------------------
Thanks for the patch. A few comments below. build.gradle <https://reviews.apache.org/r/33614/#comment140087> Could you check if this is needed? I think a compile dependency implies a testCompile dependency. log4j-appender/src/main/java/org/apache/kafka/log4jappender/KafkaLog4jAppender.java <https://reviews.apache.org/r/33614/#comment140084> Should we use Logger inside log4j? Should we use LogLog as in the original scala code? log4j-appender/src/main/java/org/apache/kafka/log4jappender/KafkaLog4jAppender.java <https://reviews.apache.org/r/33614/#comment140085> Would it be better to use the built-in StringSerializer? log4j-appender/src/main/java/org/apache/kafka/log4jappender/KafkaLog4jAppender.java <https://reviews.apache.org/r/33614/#comment140086> We can just use ConfigException. - Jun Rao On April 30, 2015, 10:53 p.m., Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33614/ > ----------------------------------------------------------- > > (Updated April 30, 2015, 10:53 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-2132 > https://issues.apache.org/jira/browse/KAFKA-2132 > > > Repository: kafka > > > Description > ------- > > KAFKA-2132: Move Log4J appender to clients module > > > Diffs > ----- > > build.gradle fef515b3b2276b1f861e7cc2e33e74c3ce5e405b > checkstyle/import-control.xml f2e6cec267e67ce8e261341e373718e14a8e8e03 > core/src/main/scala/kafka/producer/KafkaLog4jAppender.scala > 5d36a019e3dbfb93737a9cd23404dcd1c5d836d1 > core/src/test/scala/unit/kafka/log4j/KafkaLog4jAppenderTest.scala > 41366a14590d318fced0e83d6921d8035fa882da > > log4j-appender/src/main/java/org/apache/kafka/log4jappender/KafkaLog4jAppender.java > PRE-CREATION > > log4j-appender/src/test/java/org/apache/kafka/log4jappender/KafkaLog4jAppenderTest.java > PRE-CREATION > > log4j-appender/src/test/java/org/apache/kafka/log4jappender/MockKafkaLog4jAppender.java > PRE-CREATION > settings.gradle 83f764e6a4a15a5fdba232dce74a369870f26b45 > > Diff: https://reviews.apache.org/r/33614/diff/ > > > Testing > ------- > > > Thanks, > > Ashish Singh > >
