Re: Review Request 29210: Patch for KAFKA-1819

2015-01-14 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29210/#review68107 --- A couple of minor comments. Neither of these is a blocker for 0.8.2.

Re: Review Request 29210: Patch for KAFKA-1819

2015-01-12 Thread Neha Narkhede
> On Jan. 12, 2015, 10:53 p.m., Joel Koshy wrote: > > core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala, line 68 > > > > > > Actually, now that you have the check above in DeleteTopicTest, do you > > t

Re: Review Request 29210: Patch for KAFKA-1819

2015-01-12 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29210/ --- (Updated Jan. 13, 2015, 1:01 a.m.) Review request for kafka. Bugs: KAFKA-1819

Re: Review Request 29210: Patch for KAFKA-1819

2015-01-12 Thread Gwen Shapira
> On Jan. 12, 2015, 10:53 p.m., Joel Koshy wrote: > > core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala, line 251 > > > > > > Rather than an arbitrary sleep can we just use waitUntilTrue and the > > condition

Re: Review Request 29210: Patch for KAFKA-1819

2015-01-12 Thread Gwen Shapira
> On Jan. 12, 2015, 10:53 p.m., Joel Koshy wrote: > > core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala, line 68 > > > > > > Actually, now that you have the check above in DeleteTopicTest, do you > > t

Re: Review Request 29210: Patch for KAFKA-1819

2015-01-12 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29210/#review67717 --- Minor comments core/src/test/scala/unit/kafka/admin/DeleteTopicTes

Re: Review Request 29210: Patch for KAFKA-1819

2015-01-12 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29210/ --- (Updated Jan. 12, 2015, 7:17 p.m.) Review request for kafka. Bugs: KAFKA-1819

Re: Review Request 29210: Patch for KAFKA-1819

2015-01-12 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29210/ --- (Updated Jan. 12, 2015, 6:34 p.m.) Review request for kafka. Bugs: KAFKA-1819

Re: Review Request 29210: Patch for KAFKA-1819

2015-01-05 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29210/#review66733 --- core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala

Re: Review Request 29210: Patch for KAFKA-1819

2014-12-30 Thread Gwen Shapira
> On Dec. 29, 2014, 10:14 p.m., Neha Narkhede wrote: > > core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala, line 75 > > > > > > Gwen, I suggest adding this check (reading the checkpoint file and > > en

Re: Review Request 29210: Patch for KAFKA-1819

2014-12-30 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29210/ --- (Updated Dec. 31, 2014, 12:01 a.m.) Review request for kafka. Bugs: KAFKA-181

Re: Review Request 29210: Patch for KAFKA-1819

2014-12-29 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29210/#review66307 --- core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala

Re: Review Request 29210: Patch for KAFKA-1819

2014-12-26 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29210/ --- (Updated Dec. 26, 2014, 9:58 p.m.) Review request for kafka. Bugs: KAFKA-1819

Re: Review Request 29210: Patch for KAFKA-1819

2014-12-23 Thread Neha Narkhede
> On Dec. 19, 2014, 1:23 a.m., Neha Narkhede wrote: > > core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala, line 231 > > > > > > Since the bug is about entries related to deleted topics, it will be > > good to

Re: Review Request 29210: Patch for KAFKA-1819

2014-12-22 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29210/#review65866 --- core/src/main/scala/kafka/log/LogCleaner.scala

Re: Review Request 29210: Patch for KAFKA-1819

2014-12-18 Thread Gwen Shapira
> On Dec. 19, 2014, 1:23 a.m., Neha Narkhede wrote: > > core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala, line 231 > > > > > > Since the bug is about entries related to deleted topics, it will be > > good to

Re: Review Request 29210: Patch for KAFKA-1819

2014-12-18 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29210/#review65578 --- Overall, looks good. Have one suggestion below. core/src/test/scal

Review Request 29210: Patch for KAFKA-1819

2014-12-18 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29210/ --- Review request for kafka. Bugs: KAFKA-1819 https://issues.apache.org/jira/b