-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29210/
-----------------------------------------------------------

(Updated Jan. 12, 2015, 6:34 p.m.)


Review request for kafka.


Bugs: KAFKA-1819
    https://issues.apache.org/jira/browse/KAFKA-1819


Repository: kafka


Description (updated)
-------

kafka-1797; (addressing Manikumar Reddy's comment) add the 
serializer/deserializer api to the new java client; patched by Jun Rao; 
reviewed by Manikumar Reddy and Neha Narkhede


kafka-1851; OffsetFetchRequest returns extra partitions when input only 
contains unknown partitions; patched by Jun Rao; reviewed by Neha Narkhede


first pass at log clean fix


added locking


improved tests per Joel and Neha's suggestions


added cleaner test to DeleteTopicTest


Fixes to DeleteTopicTest: clean up servers after cleaner test and move cleaner 
verification to the validation function


Diffs (updated)
-----

  
clients/src/main/java/org/apache/kafka/common/serialization/StringDeserializer.java
 a3b3700a1e0716643761d7032bd32bce839d3065 
  
clients/src/main/java/org/apache/kafka/common/serialization/StringSerializer.java
 02db47f8736988343dd293fc3da03751f78a3b5c 
  
clients/src/test/java/org/apache/kafka/common/serialization/SerializationTest.java
 d550a3137c066abb5e2984ac6245574832929ff8 
  core/src/main/scala/kafka/log/LogCleaner.scala 
f8fcb843c80eec3cf3c931df6bb472c019305253 
  core/src/main/scala/kafka/log/LogCleanerManager.scala 
bcfef77ed53f94017c06a884e4db14531774a0a2 
  core/src/main/scala/kafka/log/LogManager.scala 
4ebaae00ca4b80bf15c7930bae2011d98bbec053 
  core/src/main/scala/kafka/network/SocketServer.scala 
e451592fe358158548117f47a80e807007dd8b98 
  core/src/main/scala/kafka/server/KafkaApis.scala 
2a1c0326b6e6966d8b8254bd6a1cb83ad98a3b80 
  core/src/main/scala/kafka/server/KafkaServer.scala 
1bf7d10cef23a77e716666eb16bf6d0e68bc4ebe 
  core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala 
29cc01bcef9cacd8dec1f5d662644fc6fe4994bc 
  core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala 
5bfa764638e92f217d0ff7108ec8f53193c22978 
  core/src/test/scala/unit/kafka/network/SocketServerTest.scala 
5f4d85254c384dcc27a5a84f0836ea225d3a901a 
  core/src/test/scala/unit/kafka/server/OffsetCommitTest.scala 
8c5364fa97da1be09973c176d1baeb339455d319 

Diff: https://reviews.apache.org/r/29210/diff/


Testing
-------


Thanks,

Gwen Shapira

Reply via email to