> On Jan. 12, 2015, 10:53 p.m., Joel Koshy wrote: > > core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala, line 68 > > <https://reviews.apache.org/r/29210/diff/5/?file=816890#file816890line68> > > > > Actually, now that you have the check above in DeleteTopicTest, do you > > think it is necessary to have this?
Both checks exercise the same code path, so I don't think we need both. Less code to maintain is always better, IMO. Since Neha asked to add the test in DeleteTopicTest, I want to make sure that she's ok with removing it from LogCleanerIntegrationTest. Maybe I'm missing a good reason to have both. - Gwen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29210/#review67717 ----------------------------------------------------------- On Jan. 12, 2015, 7:17 p.m., Gwen Shapira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29210/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2015, 7:17 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1819 > https://issues.apache.org/jira/browse/KAFKA-1819 > > > Repository: kafka > > > Description > ------- > > added locking > > > improved tests per Joel and Neha's suggestions > > > added cleaner test to DeleteTopicTest > > > Fixes to DeleteTopicTest: clean up servers after cleaner test and move > cleaner verification to the validation function > > > Diffs > ----- > > core/src/main/scala/kafka/log/LogCleaner.scala > f8fcb843c80eec3cf3c931df6bb472c019305253 > core/src/main/scala/kafka/log/LogCleanerManager.scala > bcfef77ed53f94017c06a884e4db14531774a0a2 > core/src/main/scala/kafka/log/LogManager.scala > 4ebaae00ca4b80bf15c7930bae2011d98bbec053 > core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala > 29cc01bcef9cacd8dec1f5d662644fc6fe4994bc > core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala > 5bfa764638e92f217d0ff7108ec8f53193c22978 > > Diff: https://reviews.apache.org/r/29210/diff/ > > > Testing > ------- > > > Thanks, > > Gwen Shapira > >
