-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29210/
-----------------------------------------------------------

(Updated Jan. 13, 2015, 1:01 a.m.)


Review request for kafka.


Bugs: KAFKA-1819
    https://issues.apache.org/jira/browse/KAFKA-1819


Repository: kafka


Description (updated)
-------

added locking


improved tests per Joel and Neha's suggestions


added cleaner test to DeleteTopicTest


Fixes to DeleteTopicTest: clean up servers after cleaner test and move cleaner 
verification to the validation function


minor fixes suggested by Joel


Diffs (updated)
-----

  core/src/main/scala/kafka/log/LogCleaner.scala 
f8fcb843c80eec3cf3c931df6bb472c019305253 
  core/src/main/scala/kafka/log/LogCleanerManager.scala 
bcfef77ed53f94017c06a884e4db14531774a0a2 
  core/src/main/scala/kafka/log/LogManager.scala 
4ebaae00ca4b80bf15c7930bae2011d98bbec053 
  core/src/test/scala/unit/kafka/admin/DeleteTopicTest.scala 
29cc01bcef9cacd8dec1f5d662644fc6fe4994bc 
  core/src/test/scala/unit/kafka/log/LogCleanerIntegrationTest.scala 
5bfa764638e92f217d0ff7108ec8f53193c22978 

Diff: https://reviews.apache.org/r/29210/diff/


Testing
-------


Thanks,

Gwen Shapira

Reply via email to