Re: Review Request 22063: Patch for KAFKA-1472

2014-06-06 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22063/#review44913 --- Ship it! Ship It! - Guozhang Wang On June 6, 2014, 5:42 a.m., Do

Re: Review Request 22063: Patch for KAFKA-1472

2014-06-05 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22063/ --- (Updated June 6, 2014, 5:42 a.m.) Review request for kafka. Bugs: KAFKA-1472

Re: Review Request 22063: Patch for KAFKA-1472

2014-06-05 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22063/ --- (Updated June 5, 2014, 5:14 p.m.) Review request for kafka. Bugs: KAFKA-1472

Re: Review Request 22063: Patch for KAFKA-1472

2014-06-05 Thread Dong Lin
> On June 5, 2014, 4:19 p.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java, > > lines 858-862 > > > > > > Could we add a global compression-rate metric too? > > Sur

Re: Review Request 22063: Patch for KAFKA-1472

2014-06-05 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22063/#review44818 --- clients/src/main/java/org/apache/kafka/clients/producer/internals/S

Re: Review Request 22063: Patch for KAFKA-1472

2014-06-04 Thread Dong Lin
> On May 30, 2014, 6:25 a.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java, > > line 130 > > > > > > When compression is not used, should we return the default value

Re: Review Request 22063: Patch for KAFKA-1472

2014-06-04 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22063/ --- (Updated June 4, 2014, 5:31 p.m.) Review request for kafka. Bugs: KAFKA-1472

Re: Review Request 22063: Patch for KAFKA-1472

2014-05-29 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22063/#review44334 --- clients/src/main/java/org/apache/kafka/clients/producer/internals/S

Review Request 22063: Patch for KAFKA-1472

2014-05-29 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22063/ --- Review request for kafka. Bugs: KAFKA-1472 https://issues.apache.org/jira/b