> On June 5, 2014, 4:19 p.m., Jun Rao wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java, > > lines 858-862 > > <https://reviews.apache.org/r/22063/diff/2/?file=603554#file603554line858> > > > > Could we add a global compression-rate metric too? > >
Sure! I will add this metric too. - Dong ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22063/#review44818 ----------------------------------------------------------- On June 4, 2014, 5:31 p.m., Dong Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22063/ > ----------------------------------------------------------- > > (Updated June 4, 2014, 5:31 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1472 > https://issues.apache.org/jira/browse/KAFKA-1472 > > > Repository: kafka > > > Description > ------- > > version 2 > > > Diffs > ----- > > > clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java > 9b1f5653548ba90defdae43940a5554066770b0a > clients/src/main/java/org/apache/kafka/common/record/Compressor.java > 0fa6dd2d6aad3dbe33c9c05406931caae4d8ecf5 > clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java > 428968cd38a7b12991f87868bf759926ff7e594e > > Diff: https://reviews.apache.org/r/22063/diff/ > > > Testing > ------- > > > Thanks, > > Dong Lin > >
