----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22063/#review44334 -----------------------------------------------------------
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java <https://reviews.apache.org/r/22063/#comment78704> Should this be a Rate() or it should be an Avg()? clients/src/main/java/org/apache/kafka/common/record/Compressor.java <https://reviews.apache.org/r/22063/#comment78705> When writtenUncompressed is 0, shall we treat the compression rate as 1.0 or -1? clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java <https://reviews.apache.org/r/22063/#comment78706> When compression is not used, should we return the default value as 1.0? - Guozhang Wang On May 29, 2014, 9:46 p.m., Dong Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22063/ > ----------------------------------------------------------- > > (Updated May 29, 2014, 9:46 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1472 > https://issues.apache.org/jira/browse/KAFKA-1472 > > > Repository: kafka > > > Description > ------- > > KAFKA-1472 Add the compression ratio metrics > > > Diffs > ----- > > > clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java > 3e83ae0fefb7578cccbd8dc0cd9b28f22e0951b2 > clients/src/main/java/org/apache/kafka/common/record/Compressor.java > 0fa6dd2d6aad3dbe33c9c05406931caae4d8ecf5 > clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java > 428968cd38a7b12991f87868bf759926ff7e594e > > Diff: https://reviews.apache.org/r/22063/diff/ > > > Testing > ------- > > > Thanks, > > Dong Lin > >
