> On May 30, 2014, 6:25 a.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java, > > line 130 > > <https://reviews.apache.org/r/22063/diff/1/?file=599342#file599342line130> > > > > When compression is not used, should we return the default value as 1.0?
On a second thought, I agree it is better to use 1.0 as default value for all "invalid" cases. > On May 30, 2014, 6:25 a.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/common/record/Compressor.java, line > > 87 > > <https://reviews.apache.org/r/22063/diff/1/?file=599341#file599341line87> > > > > When writtenUncompressed is 0, shall we treat the compression rate as > > 1.0 or -1? On a second thought, I agree it is better to use 1.0 as default value for all "invalid" cases. > On May 30, 2014, 6:25 a.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java, > > line 815 > > <https://reviews.apache.org/r/22063/diff/1/?file=599340#file599340line815> > > > > Should this be a Rate() or it should be an Avg()? oops. My bad, I should use Avg(). - Dong ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22063/#review44334 ----------------------------------------------------------- On June 4, 2014, 5:31 p.m., Dong Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22063/ > ----------------------------------------------------------- > > (Updated June 4, 2014, 5:31 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1472 > https://issues.apache.org/jira/browse/KAFKA-1472 > > > Repository: kafka > > > Description > ------- > > version 2 > > > Diffs > ----- > > > clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java > 9b1f5653548ba90defdae43940a5554066770b0a > clients/src/main/java/org/apache/kafka/common/record/Compressor.java > 0fa6dd2d6aad3dbe33c9c05406931caae4d8ecf5 > clients/src/main/java/org/apache/kafka/common/record/MemoryRecords.java > 428968cd38a7b12991f87868bf759926ff7e594e > > Diff: https://reviews.apache.org/r/22063/diff/ > > > Testing > ------- > > > Thanks, > > Dong Lin > >
