Re: Review Request 19577: Patch for KAFKA-1317

2014-03-26 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19577/#review38666 --- Ship it! Ship It! - Neha Narkhede On March 26, 2014, 10:09 p.m.,

Re: Review Request 19577: Patch for KAFKA-1317

2014-03-26 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19577/ --- (Updated March 26, 2014, 10:09 p.m.) Review request for kafka. Bugs: KAFKA-13

Re: Review Request 19577: Patch for KAFKA-1317

2014-03-26 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19577/ --- (Updated March 26, 2014, 10:05 p.m.) Review request for kafka. Bugs: KAFKA-13

Re: Review Request 19577: Patch for KAFKA-1317

2014-03-26 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19577/#review38662 --- Overall, almost ready for checkin. Few comments before we checkin -

Re: Review Request 19577: Patch for KAFKA-1317

2014-03-26 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19577/ --- (Updated March 26, 2014, 6:31 p.m.) Review request for kafka. Bugs: KAFKA-131

Re: Review Request 19577: Patch for KAFKA-1317

2014-03-26 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19577/ --- (Updated March 26, 2014, 4:48 p.m.) Review request for kafka. Bugs: KAFKA-131

Re: Review Request 19577: Patch for KAFKA-1317

2014-03-25 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19577/#review38576 --- core/src/main/scala/kafka/controller/TopicDeletionManager.scala

Re: Review Request 19577: Patch for KAFKA-1317

2014-03-25 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19577/ --- (Updated March 25, 2014, 10:20 p.m.) Review request for kafka. Bugs: KAFKA-13

Re: Review Request 19577: Patch for KAFKA-1317

2014-03-24 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19577/ --- (Updated March 24, 2014, 6:06 p.m.) Review request for kafka. Bugs: KAFKA-131

Re: Review Request 19577: Patch for KAFKA-1317

2014-03-24 Thread Timothy Chen
> On March 24, 2014, 4:20 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/controller/TopicDeletionManager.scala, line 74 > > > > > > This is probably trying to fix the problem reported in KAFKA-1307? If > > ye

Re: Review Request 19577: Patch for KAFKA-1317

2014-03-24 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19577/#review38306 --- I couldn't reproduce the shutdown problem where the DeleteTopicsThre

Re: Review Request 19577: Patch for KAFKA-1317

2014-03-23 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19577/ --- (Updated March 24, 2014, 6:48 a.m.) Review request for kafka. Bugs: KAFKA-131

Review Request 19577: Patch for KAFKA-1317

2014-03-23 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19577/ --- Review request for kafka. Bugs: KAFKA-1317 https://issues.apache.org/jira/b