----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19577/#review38662 -----------------------------------------------------------
Overall, almost ready for checkin. Few comments before we checkin - core/src/main/scala/kafka/controller/KafkaController.scala <https://reviews.apache.org/r/19577/#comment70921> Let's remove these unused imports core/src/main/scala/kafka/controller/TopicDeletionManager.scala <https://reviews.apache.org/r/19577/#comment70922> It is better to move the lock to inside the awaitTopicDeletionNotification() private method (similar to what you did for resumeTopicDeletionThread()). That way any calls to awaitTopicDeletionNotification() don't have to worry about acquiring the lock. core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala <https://reviews.apache.org/r/19577/#comment70923> Thanks for adding this test. Very cool :) - Neha Narkhede On March 26, 2014, 6:31 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19577/ > ----------------------------------------------------------- > > (Updated March 26, 2014, 6:31 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1317 > https://issues.apache.org/jira/browse/KAFKA-1317 > > > Repository: kafka > > > Description > ------- > > KAFKA-1317 Fix Kafka shutdown with delete topic on > > > Diffs > ----- > > core/src/main/scala/kafka/controller/KafkaController.scala > f12ffc2af1f739f7d46058c97f0eeed6b55da14d > core/src/main/scala/kafka/controller/TopicDeletionManager.scala > 8262e10ce4364f057e449172ace38320e44247db > core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala > 20fe93e623319fd82236eb6364d7f80bf7a256aa > > Diff: https://reviews.apache.org/r/19577/diff/ > > > Testing > ------- > > > Thanks, > > Timothy Chen > >
