----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19577/#review38576 -----------------------------------------------------------
core/src/main/scala/kafka/controller/TopicDeletionManager.scala <https://reviews.apache.org/r/19577/#comment70849> This change makes sense and is necessary, however probably not sufficient. A Condition variable's await() as well as signal() calls require the corresponding lock to be held. So, we might have to make the inLock(deleteLock) change to all the places that signal() this condition variable as well. - Neha Narkhede On March 25, 2014, 10:20 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19577/ > ----------------------------------------------------------- > > (Updated March 25, 2014, 10:20 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1317 > https://issues.apache.org/jira/browse/KAFKA-1317 > > > Repository: kafka > > > Description > ------- > > KAFKA-1317 Fix Kafka shutdown with delete topic on > > > Diffs > ----- > > core/src/main/scala/kafka/controller/KafkaController.scala > f12ffc2af1f739f7d46058c97f0eeed6b55da14d > core/src/main/scala/kafka/controller/TopicDeletionManager.scala > 8262e10ce4364f057e449172ace38320e44247db > core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala > 20fe93e623319fd82236eb6364d7f80bf7a256aa > > Diff: https://reviews.apache.org/r/19577/diff/ > > > Testing > ------- > > > Thanks, > > Timothy Chen > >
