----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19577/#review38306 -----------------------------------------------------------
I couldn't reproduce the shutdown problem where the DeleteTopicsThread fails to exit. Could you? We should definitely add a system test to cover that scenario. core/src/main/scala/kafka/controller/KafkaController.scala <https://reviews.apache.org/r/19577/#comment70346> It seems more natural to let the logic be in onControllerResignation and call that from shutdown(). That way we don't have to change the signature of shutdown() to include a flag. It is slightly confusing. core/src/main/scala/kafka/controller/TopicDeletionManager.scala <https://reviews.apache.org/r/19577/#comment70348> This is probably trying to fix the problem reported in KAFKA-1307? If yes, then this change might not be enough to fix the issue. Since the await() and signal would now have to ensure that they lock on deleteLock instead of controllerLock. - Neha Narkhede On March 24, 2014, 6:48 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19577/ > ----------------------------------------------------------- > > (Updated March 24, 2014, 6:48 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1317 > https://issues.apache.org/jira/browse/KAFKA-1317 > > > Repository: kafka > > > Description > ------- > > KAFKA-1317 Fix Kafka shutdown with delete topic on > > > Diffs > ----- > > core/src/main/scala/kafka/controller/KafkaController.scala > f12ffc2af1f739f7d46058c97f0eeed6b55da14d > core/src/main/scala/kafka/controller/TopicDeletionManager.scala > 8262e10ce4364f057e449172ace38320e44247db > > Diff: https://reviews.apache.org/r/19577/diff/ > > > Testing > ------- > > > Thanks, > > Timothy Chen > >
