[
https://issues.apache.org/jira/browse/KAFKA-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13752117#comment-13752117
]
Neha Narkhede commented on KAFKA-990:
-
+1 on v3. Also, it will be good to file a separa
[
https://issues.apache.org/jira/browse/KAFKA-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13751668#comment-13751668
]
Sriram Subramanian commented on KAFKA-990:
--
Guozhang - We have not merged addparti
[
https://issues.apache.org/jira/browse/KAFKA-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13751666#comment-13751666
]
Sriram Subramanian commented on KAFKA-990:
--
- made the dry run the default
- added
[
https://issues.apache.org/jira/browse/KAFKA-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13743970#comment-13743970
]
Guozhang Wang commented on KAFKA-990:
-
Just one more comment: as for Swapnil's 16, curr
[
https://issues.apache.org/jira/browse/KAFKA-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13743944#comment-13743944
]
Sriram Subramanian commented on KAFKA-990:
--
2.1 will do so.
2.2 We cannot make it
[
https://issues.apache.org/jira/browse/KAFKA-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13743930#comment-13743930
]
Jun Rao commented on KAFKA-990:
---
Thanks for patch v2. A few more comments.
2.1 I think it's
[
https://issues.apache.org/jira/browse/KAFKA-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13737419#comment-13737419
]
Swapnil Ghike commented on KAFKA-990:
-
Comments on v1:
I think a much clearer name for
[
https://issues.apache.org/jira/browse/KAFKA-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13737416#comment-13737416
]
Sriram Subramanian commented on KAFKA-990:
--
Neha - fixed what you suggested
Jun -
[
https://issues.apache.org/jira/browse/KAFKA-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13737199#comment-13737199
]
Swapnil Ghike commented on KAFKA-990:
-
v1 works with git apply.
> Fix
[
https://issues.apache.org/jira/browse/KAFKA-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13737162#comment-13737162
]
Swapnil Ghike commented on KAFKA-990:
-
The rebased patch also failed for me on 0.8 HEAD
[
https://issues.apache.org/jira/browse/KAFKA-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13737093#comment-13737093
]
Neha Narkhede commented on KAFKA-990:
-
1.2 If a broker goes down after the reassignment
[
https://issues.apache.org/jira/browse/KAFKA-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13737045#comment-13737045
]
Jun Rao commented on KAFKA-990:
---
Thanks for the patch. Looks good overall. Some comments.
1.
[
https://issues.apache.org/jira/browse/KAFKA-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13737024#comment-13737024
]
Joel Koshy commented on KAFKA-990:
--
It should be liveOrShuttingDownBrokerIds. This is requ
[
https://issues.apache.org/jira/browse/KAFKA-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13737017#comment-13737017
]
Guozhang Wang commented on KAFKA-990:
-
Looks good to me overall. One question though: i
[
https://issues.apache.org/jira/browse/KAFKA-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13737010#comment-13737010
]
Joel Koshy commented on KAFKA-990:
--
The rebased patch looks good - the shutdown changes I
[
https://issues.apache.org/jira/browse/KAFKA-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13735653#comment-13735653
]
Joel Koshy commented on KAFKA-990:
--
Looks like I might have looked at the wrong patch. I'l
[
https://issues.apache.org/jira/browse/KAFKA-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13735120#comment-13735120
]
Joel Koshy commented on KAFKA-990:
--
Can you elaborate on the change to shutdownBroker in K
[
https://issues.apache.org/jira/browse/KAFKA-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13733837#comment-13733837
]
Joel Koshy commented on KAFKA-990:
--
- Topics to move json file format seems unnecessarily
[
https://issues.apache.org/jira/browse/KAFKA-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13733796#comment-13733796
]
Neha Narkhede commented on KAFKA-990:
-
Thanks for the rebased patch, Sriram. Overall, t
[
https://issues.apache.org/jira/browse/KAFKA-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13732938#comment-13732938
]
Neha Narkhede commented on KAFKA-990:
-
Thanks for patch v1. Could you please fix the co
20 matches
Mail list logo
