[
https://issues.apache.org/jira/browse/KAFKA-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13751666#comment-13751666
]
Sriram Subramanian commented on KAFKA-990:
------------------------------------------
- made the dry run the default
- added some more input validations for the tool
- some renaming to the controller methods
Swapnil -
23. We seem to be updating only once. Let me know if that is not the case.
24. It is hard to batch with the way we have the code now. The
handleStateChange works per topic partition
25. That would cause us to explicitly invoke
startNewReplicasForReassignedPartition in each case outside
onPartitionReassignment which is hard to maintain.
26. Same comment as above
27. This is a lot more than what we want to do in 0.8. The issue is if we do
not update, we need to add more checks to ensure it is already done or has
failed. We can try to optimize that in trunk.
> Fix ReassignPartitionCommand and improve usability
> --------------------------------------------------
>
> Key: KAFKA-990
> URL: https://issues.apache.org/jira/browse/KAFKA-990
> Project: Kafka
> Issue Type: Bug
> Reporter: Sriram Subramanian
> Assignee: Sriram Subramanian
> Attachments: KAFKA-990-v1.patch, KAFKA-990-v1-rebased.patch,
> KAFKA-990-v2.patch, KAFKA-990-v3.patch
>
>
> 1. The tool does not register for IsrChangeListener on controller failover.
> 2. There is a race condition where the previous listener can fire on
> controller failover and the replicas can be in ISR. Even after re-registering
> the ISR listener after failover, it will never be triggered.
> 3. The input the tool is a static list which is very hard to use. To improve
> this, as a first step the tool needs to take a list of topics and list of
> brokers to do the assignment to and then generate the reassignment plan.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
