[ https://issues.apache.org/jira/browse/KAFKA-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13737416#comment-13737416 ]
Sriram Subramanian commented on KAFKA-990: ------------------------------------------ Neha - fixed what you suggested Jun - 1. KafkaController: 1.1 done 1.2 we can fail for now. we can revisit this. 1.3 done 2. ReassignPartitionsCommand 2.1 I did not do that as it makes the code ugly and it does not cause any harm. Let me know if you are strong about this. 2.2 i think it is safer to be explicit instead of using the live brokers for the move and causing perf issues 2.3 done 3. polluting the page cache is debatable. We could do the log appends on the follower by-passing the cache but when the follower becomes the leader, it could cause lot of IO. Another option is to throttle the rate at which the appends happen on the follower that reduces the sudden influx of messages at the follower and fetch requests at the leader. Both of these are outside the scope of this JIRA. > Fix ReassignPartitionCommand and improve usability > -------------------------------------------------- > > Key: KAFKA-990 > URL: https://issues.apache.org/jira/browse/KAFKA-990 > Project: Kafka > Issue Type: Bug > Reporter: Sriram Subramanian > Assignee: Sriram Subramanian > Attachments: KAFKA-990-v1.patch, KAFKA-990-v1-rebased.patch, > KAFKA-990-v2.patch > > > 1. The tool does not register for IsrChangeListener on controller failover. > 2. There is a race condition where the previous listener can fire on > controller failover and the replicas can be in ISR. Even after re-registering > the ISR listener after failover, it will never be triggered. > 3. The input the tool is a static list which is very hard to use. To improve > this, as a first step the tool needs to take a list of topics and list of > brokers to do the assignment to and then generate the reassignment plan. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira