[
https://issues.apache.org/jira/browse/KAFKA-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13743930#comment-13743930
]
Jun Rao commented on KAFKA-990:
-------------------------------
Thanks for patch v2. A few more comments.
2.1 I think it's better to guard this in the command line. The issue is that if
a user provided both options, it's not clear which one takes precedence.
2.2 In that case, we should make sure that brokerList is a mandatory field
(like zkConnect).
30. KafkaController.initializeAndMaybeTriggerPartitionReassignment(): The
following comment is weird.
// need to call method
31. Related to Swapnil's comment in #11, currently, the tool finishes after the
ZK path is created. It would be useful to add an option to check the state of
partition reassignment so that we know either all assignments have completed or
the set of partitions that are remaining.
> Fix ReassignPartitionCommand and improve usability
> --------------------------------------------------
>
> Key: KAFKA-990
> URL: https://issues.apache.org/jira/browse/KAFKA-990
> Project: Kafka
> Issue Type: Bug
> Reporter: Sriram Subramanian
> Assignee: Sriram Subramanian
> Attachments: KAFKA-990-v1.patch, KAFKA-990-v1-rebased.patch,
> KAFKA-990-v2.patch
>
>
> 1. The tool does not register for IsrChangeListener on controller failover.
> 2. There is a race condition where the previous listener can fire on
> controller failover and the replicas can be in ISR. Even after re-registering
> the ISR listener after failover, it will never be triggered.
> 3. The input the tool is a static list which is very hard to use. To improve
> this, as a first step the tool needs to take a list of topics and list of
> brokers to do the assignment to and then generate the reassignment plan.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
