[jira] [Commented] (KAFKA-2389) CommitType seems not necessary in commit().

[ https://issues.apache.org/jira/browse/KAFKA-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14741654#comment-14741654 ] ASF GitHub Bot commented on KAFKA-2389: --- Github user asfgit closed the pull request

[jira] [Commented] (KAFKA-2389) CommitType seems not necessary in commit().

[ https://issues.apache.org/jira/browse/KAFKA-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14715846#comment-14715846 ] Guozhang Wang commented on KAFKA-2389: -- Yeah, I did not think that Zookeeper API is t

[jira] [Commented] (KAFKA-2389) CommitType seems not necessary in commit().

[ https://issues.apache.org/jira/browse/KAFKA-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14715805#comment-14715805 ] Ewen Cheslack-Postava commented on KAFKA-2389: -- I'd also say that just becaus

[jira] [Commented] (KAFKA-2389) CommitType seems not necessary in commit().

[ https://issues.apache.org/jira/browse/KAFKA-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14715660#comment-14715660 ] Jiangjie Qin commented on KAFKA-2389: - [~guozhang] As you said, distinguishing sync/as

[jira] [Commented] (KAFKA-2389) CommitType seems not necessary in commit().

[ https://issues.apache.org/jira/browse/KAFKA-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14715565#comment-14715565 ] Guozhang Wang commented on KAFKA-2389: -- I'm late on this discussion, but here are my

[jira] [Commented] (KAFKA-2389) CommitType seems not necessary in commit().

[ https://issues.apache.org/jira/browse/KAFKA-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709640#comment-14709640 ] Jiangjie Qin commented on KAFKA-2389: - [~ewencp] I am modifying the code and found it

[jira] [Commented] (KAFKA-2389) CommitType seems not necessary in commit().

[ https://issues.apache.org/jira/browse/KAFKA-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709631#comment-14709631 ] Jason Gustafson commented on KAFKA-2389: [~ewencp] If I understand correctly, you

[jira] [Commented] (KAFKA-2389) CommitType seems not necessary in commit().

[ https://issues.apache.org/jira/browse/KAFKA-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709620#comment-14709620 ] Jiangjie Qin commented on KAFKA-2389: - I am also thinking about having only no paramet

[jira] [Commented] (KAFKA-2389) CommitType seems not necessary in commit().

[ https://issues.apache.org/jira/browse/KAFKA-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709609#comment-14709609 ] Jay Kreps commented on KAFKA-2389: -- I think this may be the first time Ewen has ever agre

[jira] [Commented] (KAFKA-2389) CommitType seems not necessary in commit().

[ https://issues.apache.org/jira/browse/KAFKA-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14708866#comment-14708866 ] Ewen Cheslack-Postava commented on KAFKA-2389: -- If I'm understanding people's

[jira] [Commented] (KAFKA-2389) CommitType seems not necessary in commit().

[ https://issues.apache.org/jira/browse/KAFKA-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14708587#comment-14708587 ] Jay Kreps commented on KAFKA-2389: -- I personally think the current API is preferable. I

[jira] [Commented] (KAFKA-2389) CommitType seems not necessary in commit().

[ https://issues.apache.org/jira/browse/KAFKA-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14708577#comment-14708577 ] Jason Gustafson commented on KAFKA-2389: +1 This suggestion has nice symmetry. Pas

[jira] [Commented] (KAFKA-2389) CommitType seems not necessary in commit().

[ https://issues.apache.org/jira/browse/KAFKA-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14708569#comment-14708569 ] Jiangjie Qin commented on KAFKA-2389: - Yeah, having commitAsync() and commitSync would

[jira] [Commented] (KAFKA-2389) CommitType seems not necessary in commit().

[ https://issues.apache.org/jira/browse/KAFKA-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14708553#comment-14708553 ] Jay Kreps commented on KAFKA-2389: -- I agree with you that few people will want the callba

[jira] [Commented] (KAFKA-2389) CommitType seems not necessary in commit().

[ https://issues.apache.org/jira/browse/KAFKA-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14708541#comment-14708541 ] Jiangjie Qin commented on KAFKA-2389: - [~jkreps] I think a synchronous call taking a c

[jira] [Commented] (KAFKA-2389) CommitType seems not necessary in commit().

[ https://issues.apache.org/jira/browse/KAFKA-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14708480#comment-14708480 ] Jay Kreps commented on KAFKA-2389: -- Why would not passing in a callback imply that you wa

[jira] [Commented] (KAFKA-2389) CommitType seems not necessary in commit().

[ https://issues.apache.org/jira/browse/KAFKA-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694519#comment-14694519 ] ASF GitHub Bot commented on KAFKA-2389: --- GitHub user becketqin opened a pull request

[jira] [Commented] (KAFKA-2389) CommitType seems not necessary in commit().

[ https://issues.apache.org/jira/browse/KAFKA-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14662624#comment-14662624 ] Gwen Shapira commented on KAFKA-2389: - ahhh, got it. > CommitType seems not necessary

[jira] [Commented] (KAFKA-2389) CommitType seems not necessary in commit().

[ https://issues.apache.org/jira/browse/KAFKA-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14662618#comment-14662618 ] Jiangjie Qin commented on KAFKA-2389: - [~gwenshap], we talked with [~ewencp] about thi

[jira] [Commented] (KAFKA-2389) CommitType seems not necessary in commit().

[ https://issues.apache.org/jira/browse/KAFKA-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14662612#comment-14662612 ] Gwen Shapira commented on KAFKA-2389: - mmm... that actually sounds pretty reasonable t

[jira] [Commented] (KAFKA-2389) CommitType seems not necessary in commit().

[ https://issues.apache.org/jira/browse/KAFKA-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14662572#comment-14662572 ] Jason Gustafson commented on KAFKA-2389: [~gwenshap] This only reason we've resist

[jira] [Commented] (KAFKA-2389) CommitType seems not necessary in commit().

[ https://issues.apache.org/jira/browse/KAFKA-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14662559#comment-14662559 ] Gwen Shapira commented on KAFKA-2389: - Why are we not making the API identical to Kafk

[jira] [Commented] (KAFKA-2389) CommitType seems not necessary in commit().

[ https://issues.apache.org/jira/browse/KAFKA-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14662543#comment-14662543 ] Jason Gustafson commented on KAFKA-2389: [~becket_qin] I'm definitely in favor of