[ 
https://issues.apache.org/jira/browse/KAFKA-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709631#comment-14709631
 ] 

Jason Gustafson commented on KAFKA-2389:
----------------------------------------

[~ewencp] If I understand correctly, you are proposing to drop 
commitAsync(callback). Is that right? But I can imagine the user wanting to 
commit the current offsets (whatever they are), and getting some notification 
for when it actually happens (and whether it failed). I would probably support 
all three variants: no parameters, callback, map + callback.

> CommitType seems not necessary in commit().
> -------------------------------------------
>
>                 Key: KAFKA-2389
>                 URL: https://issues.apache.org/jira/browse/KAFKA-2389
>             Project: Kafka
>          Issue Type: Sub-task
>            Reporter: Jiangjie Qin
>            Assignee: Jiangjie Qin
>
> The CommitType does not seem to be necessary in for commit(), it can be 
> inferred from whether user passed in a callback or not.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to