[
https://issues.apache.org/jira/browse/KAFKA-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14709620#comment-14709620
]
Jiangjie Qin commented on KAFKA-2389:
-------------------------------------
I am also thinking about having only no parameters & map + callback. Passing in
a null map is less common in API but it does make the API cleaner. I'll follow
this approach and submit another patch. And also glad Jay and Ewen agreed for
the first time :P
> CommitType seems not necessary in commit().
> -------------------------------------------
>
> Key: KAFKA-2389
> URL: https://issues.apache.org/jira/browse/KAFKA-2389
> Project: Kafka
> Issue Type: Sub-task
> Reporter: Jiangjie Qin
> Assignee: Jiangjie Qin
>
> The CommitType does not seem to be necessary in for commit(), it can be
> inferred from whether user passed in a callback or not.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
