[
https://issues.apache.org/jira/browse/KAFKA-2389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694519#comment-14694519
]
ASF GitHub Bot commented on KAFKA-2389:
---------------------------------------
GitHub user becketqin opened a pull request:
https://github.com/apache/kafka/pull/134
KAFKA-2389: remove commit type from new consumer.
A shot to remove commit type from new consumer. The coordinator constructor
takes a default offset commit callback mainly for testing purpose.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/becketqin/kafka KAFKA-2389
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/134.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #134
----
commit 5f332efa6c690fad730278283d8c419c6a223a8e
Author: Jiangjie Qin <becket....@gmail.com>
Date: 2015-08-11T19:41:15Z
KAFKA-2389: Remove commit type from commit()
----
> CommitType seems not necessary in commit().
> -------------------------------------------
>
> Key: KAFKA-2389
> URL: https://issues.apache.org/jira/browse/KAFKA-2389
> Project: Kafka
> Issue Type: Sub-task
> Reporter: Jiangjie Qin
> Assignee: Jiangjie Qin
>
> The CommitType does not seem to be necessary in for commit(), it can be
> inferred from whether user passed in a callback or not.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
