[
https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15815649#comment-15815649
]
Andrey commented on KAFKA-1251:
---
Hi,
Does anyone knows why "counter" metrics exposed as "ra
[
https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13958946#comment-13958946
]
Guozhang Wang commented on KAFKA-1251:
--
Just FYI I realized the per-node "request-lat
[
https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13956958#comment-13956958
]
Jay Kreps commented on KAFKA-1251:
--
Uploaded a patch that further standardizes the naming
[
https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13956956#comment-13956956
]
Jay Kreps commented on KAFKA-1251:
--
Created reviewboard https://reviews.apache.org/r/1987
[
https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13956921#comment-13956921
]
Jay Kreps commented on KAFKA-1251:
--
Agreed, those should have been combined under record-
[
https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13956900#comment-13956900
]
Guozhang Wang commented on KAFKA-1251:
--
One more thing: record-error-rate and message
[
https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13956785#comment-13956785
]
Guozhang Wang commented on KAFKA-1251:
--
Also I am assuming on the per-topic level, it
[
https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13956752#comment-13956752
]
Guozhang Wang commented on KAFKA-1251:
--
Hi Jay,
Sorry for the last minute call, but
[
https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13956688#comment-13956688
]
Jay Kreps commented on KAFKA-1251:
--
Hey [~junrao] I filed KAFKA-1346 to track the metrics
[
https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13956121#comment-13956121
]
Neha Narkhede commented on KAFKA-1251:
--
+1 on the new names
> Add metrics to the pro
[
https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13955468#comment-13955468
]
Guozhang Wang commented on KAFKA-1251:
--
+1 on the new names.
> Add metrics to the pr
[
https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13955442#comment-13955442
]
Jun Rao commented on KAFKA-1251:
The new names sound good.
Also, I am not sure if the is
[
https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13955423#comment-13955423
]
Jay Kreps commented on KAFKA-1251:
--
If anyone disagrees with those names let me know, as
[
https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13955421#comment-13955421
]
Jay Kreps commented on KAFKA-1251:
--
Yeah [~guozhang], that makes sense. Here would be the
[
https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951645#comment-13951645
]
Guozhang Wang commented on KAFKA-1251:
--
A follow-up comment about naming: for the rat
[
https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950336#comment-13950336
]
Neha Narkhede commented on KAFKA-1251:
--
Sounds good, thanks Jay! I'm a +1 on the late
[
https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950333#comment-13950333
]
Jay Kreps commented on KAFKA-1251:
--
Created reviewboard https://reviews.apache.org/r/1977
[
https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950332#comment-13950332
]
Jay Kreps commented on KAFKA-1251:
--
Okay I addressed most of the concerns people raised.
[
https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950328#comment-13950328
]
Jay Kreps commented on KAFKA-1251:
--
Created reviewboard https://reviews.apache.org/r/1977
[
https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948285#comment-13948285
]
Jay Kreps commented on KAFKA-1251:
--
Yes, I hadn't really considered this a bug. Those are
[
https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948165#comment-13948165
]
Neha Narkhede commented on KAFKA-1251:
--
Thanks for the latest patch, Jay. Overall met
[
https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947368#comment-13947368
]
Jay Kreps commented on KAFKA-1251:
--
I've addressed most of the comments.
Jun, two commen
[
https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947364#comment-13947364
]
Jay Kreps commented on KAFKA-1251:
--
Updated reviewboard https://reviews.apache.org/r/1938
[
https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942477#comment-13942477
]
Guozhang Wang commented on KAFKA-1251:
--
Cool, looks good for me now.
> Add metrics t
[
https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942454#comment-13942454
]
Jay Kreps commented on KAFKA-1251:
--
Guozhong,
1. No idea. I did a comparison between a C
[
https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942389#comment-13942389
]
Guozhang Wang commented on KAFKA-1251:
--
Review comments in the RB (some comments on m
[
https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13941241#comment-13941241
]
Jay Kreps commented on KAFKA-1251:
--
Updated reviewboard https://reviews.apache.org/r/1938
[
https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13940721#comment-13940721
]
Jay Kreps commented on KAFKA-1251:
--
Updated reviewboard https://reviews.apache.org/r/1938
[
https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13940708#comment-13940708
]
Jay Kreps commented on KAFKA-1251:
--
Updated reviewboard https://reviews.apache.org/r/1938
[
https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13940149#comment-13940149
]
Jay Kreps commented on KAFKA-1251:
--
I posted a draft patch. This patch adds a variety of
[
https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13940138#comment-13940138
]
Jay Kreps commented on KAFKA-1251:
--
Created reviewboard https://reviews.apache.org/r/1938
31 matches
Mail list logo
