[ https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13956958#comment-13956958 ]
Jay Kreps commented on KAFKA-1251: ---------------------------------- Uploaded a patch that further standardizes the naming. Specifically I use a single convention for singular/plural for rates ("response-rate" not "responses-rate") and I combined record-error-rate and message-error-rate (should have been the same to begin with). Here are the names in the current patch: Global batch-size-avg buffer-available-bytes buffer-total-bytes incoming-byte-rate outgoing-byte-rate connection-count connection-close-rate* connection-creation-rate* io-ratio* io-time-ns-avg* io-wait-ratio* io-wait-time-ns-avg* metadata-age network-io-rate* ready-partitions record-error-rate record-queue-time-avg record-queue-time-max* (not really max?) record-retry-rate record-send-rate* record-size-max records-per-request-avg* request-latency-avg request-latency-max request-rate* request-size-avg request-size-max requests-in-flight response-rate* select-rate* waiting-threads Per-node request-latency-avg* request-latency-max* response-rate* request-size-avg request-size-max outgoing-byte-rate* incoming-byte-rate* request-rate* Per-topic byte-rate record-send-rate record-retry-rate record-error-rate If you are happy with the names give me a ship it. > Add metrics to the producer > --------------------------- > > Key: KAFKA-1251 > URL: https://issues.apache.org/jira/browse/KAFKA-1251 > Project: Kafka > Issue Type: Sub-task > Components: producer > Reporter: Jay Kreps > Assignee: Jay Kreps > Attachments: KAFKA-1251.patch, KAFKA-1251.patch, KAFKA-1251.patch, > KAFKA-1251.patch, KAFKA-1251_2014-03-19_10:19:27.patch, > KAFKA-1251_2014-03-19_10:29:05.patch, KAFKA-1251_2014-03-19_17:30:32.patch, > KAFKA-1251_2014-03-25_17:07:39.patch, metrics.png, new-producer-metrics.png > > > Currently there are no metrics. -- This message was sent by Atlassian JIRA (v6.2#6252)