[ https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950332#comment-13950332 ]
Jay Kreps commented on KAFKA-1251: ---------------------------------- Okay I addressed most of the concerns people raised. Jun, I filed KAFKA-1346 for the sample time window issue. Neha, using host/port has some complications. The selector has an InetSocketAddress which it doesn't even keep around currently. We would have to grab the host from that. But that may not actually have a host name and we can't go doing a dns lookup. And in the case it is an IPv6 address the address will be riddled with ':' which is forbidden in jmx names, as indeed the host name might be. So we would have to search and replace those out. So for now I just hackily skip negative node ids. > Add metrics to the producer > --------------------------- > > Key: KAFKA-1251 > URL: https://issues.apache.org/jira/browse/KAFKA-1251 > Project: Kafka > Issue Type: Sub-task > Components: producer > Reporter: Jay Kreps > Assignee: Jay Kreps > Attachments: KAFKA-1251.patch, KAFKA-1251.patch, > KAFKA-1251_2014-03-19_10:19:27.patch, KAFKA-1251_2014-03-19_10:29:05.patch, > KAFKA-1251_2014-03-19_17:30:32.patch, KAFKA-1251_2014-03-25_17:07:39.patch, > metrics.png > > > Currently there are no metrics. -- This message was sent by Atlassian JIRA (v6.2#6252)