[ https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947368#comment-13947368 ]
Jay Kreps commented on KAFKA-1251: ---------------------------------- I've addressed most of the comments. Jun, two comments I think I need to discuss more with you: 1. Bean naming. I'm a little sketchy on naming things aggregate because that means all our metric names will be aggregate.x and many of them aren't aggregates because they aren't topic-level. Let's discuss a bit. 2. Unless you think they are particularly helpful I'd like to avoid adding more hierarchical metrics until I improve how those are done. Currently I am manually adding both levels but I think ideally we should have a concept of inheretence where if you have a sensor with another as its parent it automatically gets created with all the metric the parent has when it doesn't exist. > Add metrics to the producer > --------------------------- > > Key: KAFKA-1251 > URL: https://issues.apache.org/jira/browse/KAFKA-1251 > Project: Kafka > Issue Type: Sub-task > Components: producer > Reporter: Jay Kreps > Assignee: Jay Kreps > Attachments: KAFKA-1251.patch, KAFKA-1251_2014-03-19_10:19:27.patch, > KAFKA-1251_2014-03-19_10:29:05.patch, KAFKA-1251_2014-03-19_17:30:32.patch, > KAFKA-1251_2014-03-25_17:07:39.patch > > > Currently there are no metrics. -- This message was sent by Atlassian JIRA (v6.2#6252)