Thanks, Ismael. I added the "Testing Strategy" section to the KIP outlining
the findings.
I am also closing this vote with 3 binding and 1 non-binding +1s and no
objections.
Thanks everyone for your review and feedback.
- Dhruvil
On Tue, May 15, 2018 at 11:04 AM, Ismael Juma wrote:
> Thanks f
Thanks for the KIP Dhruvil, this is a welcome improvement! My understanding
is that you have done some work to validate that the change has the desired
effect, it would be good to include that information in the "Testing
Strategy" section.
+1 (binding)
Ismael
On Wed, May 2, 2018 at 9:27 AM Dhruv
+1 (non-binding)
On 10 May 2018 at 09:56, Rajini Sivaram wrote:
> Hi Dhruvil, Thanks for the KIP!
>
> +1 (binding)
>
> Regards,
>
> Rajini
>
> On Wed, May 9, 2018 at 9:28 PM, Dhruvil Shah wrote:
>
> > Thanks for the feedback, Jason and Ismael. I renamed the config to
> > "message.downconversion
Hi Dhruvil, Thanks for the KIP!
+1 (binding)
Regards,
Rajini
On Wed, May 9, 2018 at 9:28 PM, Dhruvil Shah wrote:
> Thanks for the feedback, Jason and Ismael. I renamed the config to
> "message.downconversion.enable".
>
> Also, as an update, I found a potential problem with one of the suggesti
Thanks for the feedback, Jason and Ismael. I renamed the config to
"message.downconversion.enable".
Also, as an update, I found a potential problem with one of the suggestions
the KIP made, specifically about the case where the size of messages after
down-conversion is greater than the size before
Maybe it should message instead of record to be consistent with
message.format.version.
On Wed, 9 May 2018, 09:04 Jason Gustafson, wrote:
> Hi Dhruvil,
>
> Thanks for the KIP. +1 from me. Just a minor nitpick on the name of the new
> config. I would suggest "record.downconversion.enable". The "r
Hi Dhruvil,
Thanks for the KIP. +1 from me. Just a minor nitpick on the name of the new
config. I would suggest "record.downconversion.enable". The "record" prefix
emphasizes what is being down-converted and similar existing configs use
"enable" rather than "enabled."
-Jason
On Wed, May 2, 2018
+1
On Wed, May 2, 2018 at 9:27 AM, Dhruvil Shah wrote:
> Hi all,
>
> I would like to start the vote on KIP-238: Efficient Memory Usage for
> Down-Conversion.
>
> For reference, the link to the KIP is here:
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-
> 283%3A+Efficient+Memory+Usage+f
Hi all,
I would like to start the vote on KIP-238: Efficient Memory Usage for
Down-Conversion.
For reference, the link to the KIP is here:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-283%3A+Efficient+Memory+Usage+for+Down-Conversion
and the discussion thread is here:
https://www.mail-a
