Thanks for the KIP Dhruvil, this is a welcome improvement! My understanding is that you have done some work to validate that the change has the desired effect, it would be good to include that information in the "Testing Strategy" section.
+1 (binding) Ismael On Wed, May 2, 2018 at 9:27 AM Dhruvil Shah <[email protected]> wrote: > Hi all, > > I would like to start the vote on KIP-238: Efficient Memory Usage for > Down-Conversion. > > For reference, the link to the KIP is here: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-283%3A+Efficient+Memory+Usage+for+Down-Conversion > > and the discussion thread is here: > https://www.mail-archive.com/[email protected]/msg86799.html > > Thanks, > Dhruvil >
