Maybe it should message instead of record to be consistent with message.format.version.
On Wed, 9 May 2018, 09:04 Jason Gustafson, <ja...@confluent.io> wrote: > Hi Dhruvil, > > Thanks for the KIP. +1 from me. Just a minor nitpick on the name of the new > config. I would suggest "record.downconversion.enable". The "record" prefix > emphasizes what is being down-converted and similar existing configs use > "enable" rather than "enabled." > > -Jason > > On Wed, May 2, 2018 at 9:35 AM, Ted Yu <yuzhih...@gmail.com> wrote: > > > +1 > > > > On Wed, May 2, 2018 at 9:27 AM, Dhruvil Shah <dhru...@confluent.io> > wrote: > > > > > Hi all, > > > > > > I would like to start the vote on KIP-238: Efficient Memory Usage for > > > Down-Conversion. > > > > > > For reference, the link to the KIP is here: > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > > 283%3A+Efficient+Memory+Usage+for+Down-Conversion > > > > > > and the discussion thread is here: > > > https://www.mail-archive.com/dev@kafka.apache.org/msg86799.html > > > > > > Thanks, > > > Dhruvil > > > > > >
