Hi Dhruvil, Thanks for the KIP! +1 (binding)
Regards, Rajini On Wed, May 9, 2018 at 9:28 PM, Dhruvil Shah <dhru...@confluent.io> wrote: > Thanks for the feedback, Jason and Ismael. I renamed the config to > "message.downconversion.enable". > > Also, as an update, I found a potential problem with one of the suggestions > the KIP made, specifically about the case where the size of messages after > down-conversion is greater than the size before, and so we are not able to > send all the messages. Both the old and new consumers expect to receive at > least one full batch of messages for each partition, and throw a > `RecordTooLargeException` if that is not the case. Because of this, I made > a small change to the KIP to make sure we are able to send at least one > full message batch for each partition. Because this is more of an internal > implementation specific change and does not affect user-visible > functionality in any way, I went ahead and updated the KIP with this logic > (under the "Ensuring Consumer Progress" section). > > Thanks, > Dhruvil > > On Wed, May 9, 2018 at 9:09 AM, Ismael Juma <mli...@juma.me.uk> wrote: > > > Maybe it should message instead of record to be consistent with > > message.format.version. > > > > On Wed, 9 May 2018, 09:04 Jason Gustafson, <ja...@confluent.io> wrote: > > > > > Hi Dhruvil, > > > > > > Thanks for the KIP. +1 from me. Just a minor nitpick on the name of the > > new > > > config. I would suggest "record.downconversion.enable". The "record" > > prefix > > > emphasizes what is being down-converted and similar existing configs > use > > > "enable" rather than "enabled." > > > > > > -Jason > > > > > > On Wed, May 2, 2018 at 9:35 AM, Ted Yu <yuzhih...@gmail.com> wrote: > > > > > > > +1 > > > > > > > > On Wed, May 2, 2018 at 9:27 AM, Dhruvil Shah <dhru...@confluent.io> > > > wrote: > > > > > > > > > Hi all, > > > > > > > > > > I would like to start the vote on KIP-238: Efficient Memory Usage > for > > > > > Down-Conversion. > > > > > > > > > > For reference, the link to the KIP is here: > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > > > > 283%3A+Efficient+Memory+Usage+for+Down-Conversion > > > > > > > > > > and the discussion thread is here: > > > > > https://www.mail-archive.com/dev@kafka.apache.org/msg86799.html > > > > > > > > > > Thanks, > > > > > Dhruvil > > > > > > > > > > > > > > >
