Re: [VOTE] - KIP-213 (new vote) - Simplified and revised.

2019-10-20 Thread Guozhang Wang
Thanks for the catch John, the JIRA description looks good! On Sat, Oct 19, 2019 at 11:43 PM Matthias J. Sax wrote: > Thanks John! > > Good catch! > > On 10/17/19 12:11 PM, Adam Bellemare wrote: > > Awesome. Thanks John for fixing this! > > > > On Thu, Oct 17, 2019 at 3:07 PM John Roesler wrote

Re: [VOTE] - KIP-213 (new vote) - Simplified and revised.

2019-10-19 Thread Matthias J. Sax
Thanks John! Good catch! On 10/17/19 12:11 PM, Adam Bellemare wrote: > Awesome. Thanks John for fixing this! > > On Thu, Oct 17, 2019 at 3:07 PM John Roesler wrote: > >> Hello all, >> >> While writing some new test cases for foreign key joins (as accepted >> in KIP-213), I realized that there

Re: [VOTE] - KIP-213 (new vote) - Simplified and revised.

2019-10-17 Thread Adam Bellemare
Awesome. Thanks John for fixing this! On Thu, Oct 17, 2019 at 3:07 PM John Roesler wrote: > Hello all, > > While writing some new test cases for foreign key joins (as accepted > in KIP-213), I realized that there was an oversight in the review > process: we only proposed to add join methods that

Re: [VOTE] - KIP-213 (new vote) - Simplified and revised.

2019-10-17 Thread John Roesler
Hello all, While writing some new test cases for foreign key joins (as accepted in KIP-213), I realized that there was an oversight in the review process: we only proposed to add join methods that take a Materialized parameter. This poses an unnecessary burden on users who don't _need_ to materia

Re: [VOTE] - KIP-213 (new vote) - Simplified and revised.

2019-03-12 Thread Adam Bellemare
Done and done. I will begin work on bringing the previous PR up to date with the KIP. Thanks all Adam On Tue, Mar 12, 2019 at 1:17 AM Guozhang Wang wrote: > Hello Adam, > > Thank YOU for all the patience going through this process! > > Could you update the KIP pages (including the parent page

Re: [VOTE] - KIP-213 (new vote) - Simplified and revised.

2019-03-11 Thread Guozhang Wang
Hello Adam, Thank YOU for all the patience going through this process! Could you update the KIP pages (including the parent page) with the newest status as well? Thanks. Guozhang On Mon, Mar 11, 2019 at 6:12 PM Adam Bellemare wrote: > Thanks to everyone, including John, Guozhang, Matthias an

Re: [VOTE] - KIP-213 (new vote) - Simplified and revised.

2019-03-11 Thread Adam Bellemare
Thanks to everyone, including John, Guozhang, Matthias and Jan for all the help! I do believe that makes 3 binding and 3 non-binding, vote passes. Thanks folks > On Mar 11, 2019, at 5:02 PM, Matthias J. Sax wrote: > > Thanks a lot for putting this together Adam and Jan! > > +1 (binding) > >

Re: [VOTE] - KIP-213 (new vote) - Simplified and revised.

2019-03-11 Thread Matthias J. Sax
Thanks a lot for putting this together Adam and Jan! +1 (binding) -Matthias On 2/15/19 11:27 AM, Adam Bellemare wrote: > Hi Bill > > Now that you are a committer, does your vote add a +1 to binding? Can you > recast it if you believe this is a sound decision? I am eager to finally > finish

Re: [VOTE] - KIP-213 (new vote) - Simplified and revised.

2019-02-15 Thread Matthias J. Sax
I think, he needs to re-cast his vote. -Matthias On 2/15/19 5:49 AM, Adam Bellemare wrote: > Hi all > > Since Bill is now a committer, the vote is changed to 3 binding and 3 > non-binding (unless I am somehow mistaken - please let me know!). In this > case, I believe the vote passes. > > Than

Re: [VOTE] - KIP-213 (new vote) - Simplified and revised.

2019-02-15 Thread Adam Bellemare
Hi Bill Now that you are a committer, does your vote add a +1 to binding? Can you recast it if you believe this is a sound decision? I am eager to finally finish up this KIP that has been open so long. Thanks Adam > On Feb 15, 2019, at 12:50 PM, Matthias J. Sax wrote: > > I think, he need

Re: [VOTE] - KIP-213 (new vote) - Simplified and revised.

2019-02-15 Thread Adam Bellemare
Hi all Since Bill is now a committer, the vote is changed to 3 binding and 3 non-binding (unless I am somehow mistaken - please let me know!). In this case, I believe the vote passes. Thanks Adam > On Jan 24, 2019, at 7:28 PM, Adam Bellemare wrote: > > Bumping this vote because I don't wan

Re: [VOTE] - KIP-213 (new vote) - Simplified and revised.

2019-01-24 Thread Adam Bellemare
Bumping this vote because I don't want it to languish. It is very unlikely to go into 2.2 at this point, but I would like to avoid resurrecting a dead thread in 30 days time. On Tue, Jan 15, 2019 at 5:07 PM Adam Bellemare wrote: > All good Matthias. If it doesn’t get in for 2.2 I’ll just do it f

Re: [VOTE] - KIP-213 (new vote) - Simplified and revised.

2019-01-15 Thread Adam Bellemare
All good Matthias. If it doesn’t get in for 2.2 I’ll just do it for the next release. Thanks > On Jan 15, 2019, at 12:25 PM, Matthias J. Sax wrote: > > I'll try to review the KIP before the deadline, but as I am acting as > release manager and also working on KIP-258, I cannot promise. Even i

Re: [VOTE] - KIP-213 (new vote) - Simplified and revised.

2019-01-15 Thread Matthias J. Sax
I'll try to review the KIP before the deadline, but as I am acting as release manager and also working on KIP-258, I cannot promise. Even if we make the voting deadline, it might also be tight to review the PR, as it seems to be big and complicated. I'll try my very best to get it into 2.2... -M

Re: [VOTE] - KIP-213 (new vote) - Simplified and revised.

2019-01-15 Thread Adam Bellemare
If I can get one more binding vote in here, I may be able to get this out for the 2.2 release in February. Currently at: 2 binding, 4 non-binding. On Sun, Jan 13, 2019 at 2:41 PM Patrik Kleindl wrote: > +1 (non-binding) > I have followed the discussion too and think this feature will be very

Re: [VOTE] - KIP-213 (new vote) - Simplified and revised.

2019-01-13 Thread Patrik Kleindl
+1 (non-binding) I have followed the discussion too and think this feature will be very helpful. Thanks Adam for staying on this. Best regards Patrik > Am 13.01.2019 um 19:55 schrieb Paul Whalen : > > +1 non binding. I haven't contributed at all to discussion but have > followed since Adam rein

Re: [VOTE] - KIP-213 (new vote) - Simplified and revised.

2019-01-13 Thread Paul Whalen
+1 non binding. I haven't contributed at all to discussion but have followed since Adam reinvigorated it a few months ago and am very excited about it. It would be a huge help on the project I'm working on. On Fri, Jan 11, 2019 at 9:05 AM Adam Bellemare wrote: > Thanks all - > > So far that's

Re: [VOTE] - KIP-213 (new vote) - Simplified and revised.

2019-01-11 Thread Adam Bellemare
Thanks all - So far that's +2 Binding, +2 non-binding If we get a few more votes I can likely get this out as part of the Kafka 2.2 release, as the KIP Freeze is Jan 24, 2019. The current PR I have could be modified to match the PR in short order. Adam On Fri, Jan 11, 2019 at 7:11 AM Damian Gu

Re: [VOTE] - KIP-213 (new vote) - Simplified and revised.

2019-01-11 Thread Damian Guy
+1 binding On Thu, 10 Jan 2019 at 16:57, Bill Bejeck wrote: > +1 from me. Great job on the KIP. > > -Bill > > On Thu, Jan 10, 2019 at 11:35 AM John Roesler wrote: > > > It's a +1 (nonbinding) from me as well. > > > > Thanks for sticking with this, Adam! > > -John > > > > On Wed, Jan 9, 2019 at

Re: [VOTE] - KIP-213 (new vote) - Simplified and revised.

2019-01-10 Thread Bill Bejeck
+1 from me. Great job on the KIP. -Bill On Thu, Jan 10, 2019 at 11:35 AM John Roesler wrote: > It's a +1 (nonbinding) from me as well. > > Thanks for sticking with this, Adam! > -John > > On Wed, Jan 9, 2019 at 6:22 PM Guozhang Wang wrote: > > > Hello Adam, > > > > I'm +1 on the current propo

Re: [VOTE] - KIP-213 (new vote) - Simplified and revised.

2019-01-10 Thread John Roesler
It's a +1 (nonbinding) from me as well. Thanks for sticking with this, Adam! -John On Wed, Jan 9, 2019 at 6:22 PM Guozhang Wang wrote: > Hello Adam, > > I'm +1 on the current proposal, thanks! > > > Guozhang > > On Mon, Jan 7, 2019 at 6:13 AM Adam Bellemare > wrote: > > > Hi All > > > > I woul

Re: [VOTE] - KIP-213 (new vote) - Simplified and revised.

2019-01-09 Thread Guozhang Wang
Hello Adam, I'm +1 on the current proposal, thanks! Guozhang On Mon, Jan 7, 2019 at 6:13 AM Adam Bellemare wrote: > Hi All > > I would like to call a new vote on KIP-213. The design has changed > substantially. Perhaps more importantly, the KIP and associated > documentation has been greatly

[VOTE] - KIP-213 (new vote) - Simplified and revised.

2019-01-07 Thread Adam Bellemare
Hi All I would like to call a new vote on KIP-213. The design has changed substantially. Perhaps more importantly, the KIP and associated documentation has been greatly simplified. I know this KIP has been on the mailing list for a long time, but the help from John Roesler and Guozhang Wang have h