Thanks to everyone, including John, Guozhang, Matthias and Jan for all the help!
I do believe that makes 3 binding and 3 non-binding, vote passes. Thanks folks > On Mar 11, 2019, at 5:02 PM, Matthias J. Sax <matth...@confluent.io> wrote: > > Thanks a lot for putting this together Adam and Jan! > > +1 (binding) > > > > -Matthias > >> On 2/15/19 11:27 AM, Adam Bellemare wrote: >> Hi Bill >> >> Now that you are a committer, does your vote add a +1 to binding? Can you >> recast it if you believe this is a sound decision? I am eager to finally >> finish up this KIP that has been open so long. >> >> Thanks >> >> Adam >> >>> On Feb 15, 2019, at 12:50 PM, Matthias J. Sax <matth...@confluent.io> wrote: >>> >>> I think, he needs to re-cast his vote. >>> >>> -Matthias >>> >>>> On 2/15/19 5:49 AM, Adam Bellemare wrote: >>>> Hi all >>>> >>>> Since Bill is now a committer, the vote is changed to 3 binding and 3 >>>> non-binding (unless I am somehow mistaken - please let me know!). In this >>>> case, I believe the vote passes. >>>> >>>> Thanks >>>> >>>> Adam >>>> >>>>> On Jan 24, 2019, at 7:28 PM, Adam Bellemare <adam.bellem...@gmail.com> >>>>> wrote: >>>>> >>>>> Bumping this vote because I don't want it to languish. It is very >>>>> unlikely to go into 2.2 at this point, but I would like to avoid >>>>> resurrecting a dead thread in 30 days time. >>>>> >>>>>> On Tue, Jan 15, 2019 at 5:07 PM Adam Bellemare >>>>>> <adam.bellem...@gmail.com> wrote: >>>>>> All good Matthias. If it doesn’t get in for 2.2 I’ll just do it for the >>>>>> next release. >>>>>> >>>>>> Thanks >>>>>> >>>>>>> On Jan 15, 2019, at 12:25 PM, Matthias J. Sax <matth...@confluent.io> >>>>>>> wrote: >>>>>>> >>>>>>> I'll try to review the KIP before the deadline, but as I am acting as >>>>>>> release manager and also working on KIP-258, I cannot promise. Even if >>>>>>> we make the voting deadline, it might also be tight to review the PR, as >>>>>>> it seems to be big and complicated. >>>>>>> >>>>>>> I'll try my very best to get it into 2.2... >>>>>>> >>>>>>> >>>>>>> -Matthias >>>>>>> >>>>>>>> On 1/15/19 3:27 AM, Adam Bellemare wrote: >>>>>>>> If I can get one more binding vote in here, I may be able to get this >>>>>>>> out >>>>>>>> for the 2.2 release in February. >>>>>>>> >>>>>>>> Currently at: >>>>>>>> 2 binding, 4 non-binding. >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> On Sun, Jan 13, 2019 at 2:41 PM Patrik Kleindl <pklei...@gmail.com> >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>> +1 (non-binding) >>>>>>>>> I have followed the discussion too and think this feature will be very >>>>>>>>> helpful. >>>>>>>>> Thanks Adam for staying on this. >>>>>>>>> Best regards >>>>>>>>> Patrik >>>>>>>>> >>>>>>>>>> Am 13.01.2019 um 19:55 schrieb Paul Whalen <pgwha...@gmail.com>: >>>>>>>>>> >>>>>>>>>> +1 non binding. I haven't contributed at all to discussion but have >>>>>>>>>> followed since Adam reinvigorated it a few months ago and am very >>>>>>>>>> excited >>>>>>>>>> about it. It would be a huge help on the project I'm working on. >>>>>>>>>> >>>>>>>>>> On Fri, Jan 11, 2019 at 9:05 AM Adam Bellemare >>>>>>>>>> <adam.bellem...@gmail.com >>>>>>>>>> >>>>>>>>>> wrote: >>>>>>>>>> >>>>>>>>>>> Thanks all - >>>>>>>>>>> >>>>>>>>>>> So far that's +2 Binding, +2 non-binding >>>>>>>>>>> >>>>>>>>>>> If we get a few more votes I can likely get this out as part of the >>>>>>>>> Kafka >>>>>>>>>>> 2.2 release, as the KIP Freeze is Jan 24, 2019. The current PR I >>>>>>>>>>> have >>>>>>>>> could >>>>>>>>>>> be modified to match the PR in short order. >>>>>>>>>>> >>>>>>>>>>> Adam >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>>> On Fri, Jan 11, 2019 at 7:11 AM Damian Guy <damian....@gmail.com> >>>>>>>>> wrote: >>>>>>>>>>>> >>>>>>>>>>>> +1 binding >>>>>>>>>>>> >>>>>>>>>>>>> On Thu, 10 Jan 2019 at 16:57, Bill Bejeck <bbej...@gmail.com> >>>>>>>>>>>>> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>> +1 from me. Great job on the KIP. >>>>>>>>>>>>> >>>>>>>>>>>>> -Bill >>>>>>>>>>>>> >>>>>>>>>>>>> On Thu, Jan 10, 2019 at 11:35 AM John Roesler <j...@confluent.io> >>>>>>>>>>> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>>> It's a +1 (nonbinding) from me as well. >>>>>>>>>>>>>> >>>>>>>>>>>>>> Thanks for sticking with this, Adam! >>>>>>>>>>>>>> -John >>>>>>>>>>>>>> >>>>>>>>>>>>>> On Wed, Jan 9, 2019 at 6:22 PM Guozhang Wang <wangg...@gmail.com> >>>>>>>>>>>> wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>>> Hello Adam, >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> I'm +1 on the current proposal, thanks! >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Guozhang >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> On Mon, Jan 7, 2019 at 6:13 AM Adam Bellemare < >>>>>>>>>>>>> adam.bellem...@gmail.com> >>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Hi All >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> I would like to call a new vote on KIP-213. The design has >>>>>>>>>>> changed >>>>>>>>>>>>>>>> substantially. Perhaps more importantly, the KIP and associated >>>>>>>>>>>>>>>> documentation has been greatly simplified. I know this KIP has >>>>>>>>>>> been >>>>>>>>>>>>> on >>>>>>>>>>>>>>> the >>>>>>>>>>>>>>>> mailing list for a long time, but the help from John Roesler >>>>>>>>>>>>>>>> and >>>>>>>>>>>>>> Guozhang >>>>>>>>>>>>>>>> Wang have helped put it into a much better state. I would >>>>>>>>>>>> appreciate >>>>>>>>>>>>>> any >>>>>>>>>>>>>>>> feedback or votes. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-213+Support+non-key+joining+in+KTable >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Thank you >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Adam Bellemare >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>> -- Guozhang >>>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>> >>>> >>> >