Re: [DISCUSS] KIP-843 Adding metricOrElseCreate method to Metrics.

Hi Sagar, Yes, I think I misunderstood your KIP. I have no other comments, then. Thank you. Luke On Tue, May 31, 2022 at 12:46 PM Sagar wrote: > Hey Luke, > > Actually the addMetric still throws IllegalArgumentException. The new > method that is being introduced as part of the KIP doesn't thro

Jenkins build is unstable: Kafka » Kafka Branch Builder » trunk #963

See

Re: [VOTE] KIP-843: Adding metricOrElseCreate method to Metrics

Hi Ismael, I guess in that case, we will have to go with the name *metric*- similar to *sensor* - which David pointed out above because I think that's the closest method which either gets or creates a new sensor. Current addMetric in the Metrics class throw an IllegalArguementException when the me

Re: [DISCUSS] KIP-843 Adding metricOrElseCreate method to Metrics.

Hey Luke, Actually the addMetric still throws IllegalArgumentException. The new method that is being introduced as part of the KIP doesn't throw any exceptions. Also, the KIP was an afterthought, which came up during the PR review of this: https://github.com/apache/kafka/pull/12121 Let me know if

Re: [DISCUSS] KIP-843 Adding metricOrElseCreate method to Metrics.

Hi Sagar, Thanks for the KIP. In the `Compatibility` section, you mentioned: *The changes are backward compatible and needs no deprecation/migration.* But as you said, we won't throw `IllegalArgumentException` in `addMetric` method. Isn't that the compatibility issue that should be put in compat

Re: [DISCUSS] KIP-844: Transactional State Stores

Thanks for the KIP proposal Alex. 1. Configuration default You mention applications using streams DSL with built-in rocksDB state store will get transactional state stores by default when EOS is enabled, but the default implementation for apps using PAPI will fallback to non-transactional behavior

[jira] [Resolved] (KAFKA-13946) setMetadataDirectory() method in builder for ControllerNode has no parameters

[ https://issues.apache.org/jira/browse/KAFKA-13946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-13946. - Resolution: Fixed > setMetadataDirectory() method in builder for ControllerNode has no p

Re: [VOTE] KIP-843: Adding metricOrElseCreate method to Metrics

I think it's confusing to use two completely different naming conventions in the same class. We either stick with the existing convention or we create a new one and deprecate old method(s). I am not sure there is enough value in this case for the latter, but it would be good to hear what others thi

Re: [VOTE] KIP-846: Processor-level Streams metrics for records/bytes Producedd

+1 (binding) -Bill On Mon, May 30, 2022 at 4:49 AM Sagar wrote: > +1 (non-binding). > > Thanks! > Sagar. > > On Mon, May 30, 2022 at 1:11 PM Bruno Cadonna wrote: > > > +1 (binding) > > > > Thanks! > > Bruno > > > > On 30.05.22 09:36, Sophie Blee-Goldman wrote: > > > Hey all, > > > > > > I'd

Re: [DISCUSS] KIP-846: Task-level Streams metrics for bytes/records Produced

Thanks for the KIP Sophie. I'm in favor of this change as well. I don't have any comments in addition to the ones already expressed. -Bill On Mon, May 30, 2022 at 4:55 AM Sagar wrote: > Hi Sophie, > > A very minor comment but you might want to remove this KIP template related > information fro

Re: Re: Re: [DISCUSS] KIP-842: Add richer group offset reset mechanisms

Hi, Ziming. I thought about it again and thought it might be better to add an additional auxiliaryStrategy, so that we can implement more auxiliary strategies in this way, not just nearest. What do you think? Best, hudeqi > -原始邮件- > 发件人: hudeqi <16120...@bjtu.edu.cn> > 发送时间: 2022-05-30

Re: [Vote] KIP-787 - MM2 Interface to manage Kafka resources

Hi, Can I get a vote on this, please? Thanks On Wed, May 25, 2022 at 11:15 PM Omnia Ibrahim wrote: > Hi, > I'd like to start a vote on KIP-787 > https://cwiki.apache.org/confluence/display/KAFKA/KIP-787 > %3A+MM2+Interface+to+manage+Kafka+resources >

Re: [DISCUSS] KIP-844: Transactional State Stores

Thanks for the PR, Alex! I am also glad to see this coming. 1. Configuration I would also prefer to restrict the configuration of transactional on the state sore. Ideally, calling method transactional() on the state store would be enough. An option on the store builder would make it possibl

Re: [VOTE] KIP-843: Adding metricOrElseCreate method to Metrics

Hi, I would also lean towards getOrCreateMetric() for the reasons pointed out by Sagar. But I am fine either way. Best, Bruno On 30.05.22 10:54, Sagar wrote: Hi Bruno/David, Thanks for the suggestions. I would personally lean towards using getOrCreateMetric as it clearly explains the intent

[jira] [Created] (KAFKA-13948) Don't catch and re-throw exception unnecessarily

Divij Vaidya created KAFKA-13948: Summary: Don't catch and re-throw exception unnecessarily Key: KAFKA-13948 URL: https://issues.apache.org/jira/browse/KAFKA-13948 Project: Kafka Issue Type:

Re: [VOTE] KIP-843: Adding metricOrElseCreate method to Metrics

Hi Bruno/David, Thanks for the suggestions. I would personally lean towards using getOrCreateMetric as it clearly explains the intent. Having said that, if we want to use just metric(similar to sensor), that should also be ok. Just that I feel getOrCreateMetric is easily understandable. Thanks! S

[jira] [Created] (KAFKA-13947) Format strings appropriately for their argument types

Divij Vaidya created KAFKA-13947: Summary: Format strings appropriately for their argument types Key: KAFKA-13947 URL: https://issues.apache.org/jira/browse/KAFKA-13947 Project: Kafka Issue T

Re: [VOTE] KIP-846: Processor-level Streams metrics for records/bytes Producedd

+1 (non-binding). Thanks! Sagar. On Mon, May 30, 2022 at 1:11 PM Bruno Cadonna wrote: > +1 (binding) > > Thanks! > Bruno > > On 30.05.22 09:36, Sophie Blee-Goldman wrote: > > Hey all, > > > > I'd like to kick off the voting thread for the KIP I proposed to add > > processor-level "bytes/recor

Re: [DISCUSS] KIP-846: Task-level Streams metrics for bytes/records Produced

Hi Sophie, A very minor comment but you might want to remove this KIP template related information from the top of the KIP: *This page is meant as a template for writing a KIP . To create a KIP choose Tools->Copy on th

Re: [VOTE] KIP-843: Adding metricOrElseCreate method to Metrics

Hi all, Looking at the current Metrics' API, we have `sensor` which gets or creates a sensor. How about using `metric` to follow the same naming convention? Best, David On Mon, May 30, 2022 at 9:18 AM Bruno Cadonna wrote: > > Hi Sagar, > Hi Ismael, > > what about getOrCreateMetric()? > > Best,

Re: [VOTE] KIP-846: Processor-level Streams metrics for records/bytes Producedd

+1 (binding) Thanks! Bruno On 30.05.22 09:36, Sophie Blee-Goldman wrote: Hey all, I'd like to kick off the voting thread for the KIP I proposed to add processor-level "bytes/records produced" metrics to Kafka Streams. Thanks! KIP-846: Task-level Streams metrics for bytes/records Produced <

[VOTE] KIP-846: Processor-level Streams metrics for records/bytes Producedd

Hey all, I'd like to kick off the voting thread for the KIP I proposed to add processor-level "bytes/records produced" metrics to Kafka Streams. Thanks! KIP-846: Task-level Streams metrics for bytes/records Produced C

Re: [DISCUSS] KIP-846: Task-level Streams metrics for bytes/records Produced

> > Why does the title of the KIP talk about task-level metrics, but the > specified metrics are on processor-level? Ah, my mistake -- it should indeed say "processor-level metrics". Thanks for the catch Bruno, the title has been fixed. Since there don't seem to be any concerns I'll proceed with

Re: Re: [DISCUSS] KIP-842: Add richer group offset reset mechanisms

Thank you for your reply. According to the current implementation in pull request, it may not be possible to directly remove the enumeration value of nearest. However, on the whole, putting nearest in the OffsetResetStrategy enumeration class may cause some misunderstandings in use. There are tw

Re: [VOTE] KIP-843: Adding metricOrElseCreate method to Metrics

Hi Sagar, Hi Ismael, what about getOrCreateMetric()? Best, Bruno On 28.05.22 18:56, Sagar wrote: Hi Ismael, Actually Bruno suggested renaming it to getMetricOrElseCreate and we decided to go ahead with that one. These were the only names that we considered for the KIP. Thanks! Sagar. On S

Re: [DISCUSS] KIP-846: Task-level Streams metrics for bytes/records Produced

Thanks for the KIP, Sophie! I am also in favor of this KIP! I have one minor question: Why does the title of the KIP talk about task-level metrics, but the specified metrics are on processor-level? For the rest, I am +1. Best, Bruno On 29.05.22 00:20, John Roesler wrote: Thanks for the we