I think it's confusing to use two completely different naming conventions in the same class. We either stick with the existing convention or we create a new one and deprecate old method(s). I am not sure there is enough value in this case for the latter, but it would be good to hear what others think.
Ismael On Mon, May 30, 2022, 2:08 AM Bruno Cadonna <cado...@apache.org> wrote: > Hi, > > I would also lean towards getOrCreateMetric() for the reasons pointed > out by Sagar. But I am fine either way. > > Best, > Bruno > > On 30.05.22 10:54, Sagar wrote: > > Hi Bruno/David, > > > > Thanks for the suggestions. I would personally lean towards using > > getOrCreateMetric as it clearly explains the intent. Having said that, if > > we want to use just metric(similar to sensor), that should also be ok. > Just > > that I feel getOrCreateMetric is easily understandable. > > > > Thanks! > > Sagar. > > > > On Mon, May 30, 2022 at 2:16 PM David Jacot <dja...@confluent.io.invalid > > > > wrote: > > > >> Hi all, > >> > >> Looking at the current Metrics' API, we have `sensor` which gets or > creates > >> a sensor. How about using `metric` to follow the same naming convention? > >> > >> Best, > >> David > >> > >> On Mon, May 30, 2022 at 9:18 AM Bruno Cadonna <cado...@apache.org> > wrote: > >>> > >>> Hi Sagar, > >>> Hi Ismael, > >>> > >>> what about getOrCreateMetric()? > >>> > >>> Best, > >>> Bruno > >>> > >>> > >>> On 28.05.22 18:56, Sagar wrote: > >>>> Hi Ismael, > >>>> > >>>> Actually Bruno suggested renaming it to getMetricOrElseCreate and we > >>>> decided to go ahead with that one. These were the only names that we > >>>> considered for the KIP. > >>>> > >>>> Thanks! > >>>> Sagar. > >>>> > >>>> > >>>> On Sat, May 28, 2022 at 8:19 PM Ismael Juma <ism...@juma.me.uk> > wrote: > >>>> > >>>>> Thanks for the KIP. The method makes sense, but the name is a bit > >> verbose. > >>>>> Have we considered a more concise name? > >>>>> > >>>>> Ismael > >>>>> > >>>>> On Tue, May 24, 2022, 4:49 AM Sagar <sagarmeansoc...@gmail.com> > >> wrote: > >>>>> > >>>>>> Hi All, > >>>>>> > >>>>>> I would like to open a voting thread for the following KIP: > >>>>>> > >>>>>> > >>>>>> > >>>>> > >> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-843%3A+Adding+metricOrElseCreate+method+to+Metrics > >>>>>> > >>>>>> Thanks! > >>>>>> Sagar. > >>>>>> > >>>>> > >>>> > >> > > >
