Hi all, Looking at the current Metrics' API, we have `sensor` which gets or creates a sensor. How about using `metric` to follow the same naming convention?
Best, David On Mon, May 30, 2022 at 9:18 AM Bruno Cadonna <cado...@apache.org> wrote: > > Hi Sagar, > Hi Ismael, > > what about getOrCreateMetric()? > > Best, > Bruno > > > On 28.05.22 18:56, Sagar wrote: > > Hi Ismael, > > > > Actually Bruno suggested renaming it to getMetricOrElseCreate and we > > decided to go ahead with that one. These were the only names that we > > considered for the KIP. > > > > Thanks! > > Sagar. > > > > > > On Sat, May 28, 2022 at 8:19 PM Ismael Juma <ism...@juma.me.uk> wrote: > > > >> Thanks for the KIP. The method makes sense, but the name is a bit verbose. > >> Have we considered a more concise name? > >> > >> Ismael > >> > >> On Tue, May 24, 2022, 4:49 AM Sagar <sagarmeansoc...@gmail.com> wrote: > >> > >>> Hi All, > >>> > >>> I would like to open a voting thread for the following KIP: > >>> > >>> > >>> > >> https://cwiki.apache.org/confluence/display/KAFKA/KIP-843%3A+Adding+metricOrElseCreate+method+to+Metrics > >>> > >>> Thanks! > >>> Sagar. > >>> > >> > >
