Re: Review Request 25995: Patch for KAFKA-1650

2014-12-09 Thread Jiangjie Qin
> On Dec. 10, 2014, 5:09 a.m., Jun Rao wrote: > > Haven't looked at your new patch yet. It seems that the following tests > > start to fail after your commit. They seem to pass if run individually, but > > always fail if you run all unit tests. Could you take a look and at least > > understand

Re: Review Request 25995: Patch for KAFKA-1650

2014-12-09 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25995/#review64505 --- Haven't looked at your new patch yet. It seems that the following te

[jira] [Updated] (KAFKA-1797) add the serializer/deserializer api to the new java client

2014-12-09 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1797: --- Attachment: kafka-1797_2014-12-09_18:48:33.patch > add the serializer/deserializer api to the new java client

[jira] [Commented] (KAFKA-1797) add the serializer/deserializer api to the new java client

2014-12-09 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14240563#comment-14240563 ] Jun Rao commented on KAFKA-1797: Updated reviewboard https://reviews.apache.org/r/28423/di

Re: Review Request 28423: Patch for kafka-1797

2014-12-09 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28423/ --- (Updated Dec. 10, 2014, 2:48 a.m.) Review request for kafka. Bugs: kafka-1797

[jira] [Comment Edited] (KAFKA-1810) Add IP Filtering / Whitelists-Blacklists

2014-12-09 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14240484#comment-14240484 ] Jeff Holoman edited comment on KAFKA-1810 at 12/10/14 1:38 AM: -

[jira] [Commented] (KAFKA-1810) Add IP Filtering / Whitelists-Blacklists

2014-12-09 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14240484#comment-14240484 ] Jeff Holoman commented on KAFKA-1810: - [~bosco] I did note the broader security-rela

[jira] [Commented] (KAFKA-1772) Add an Admin message type for request response

2014-12-09 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14240460#comment-14240460 ] Neha Narkhede commented on KAFKA-1772: -- bq. The responses for different entities (top

Re: Review Request 27693: Patch for KAFKA-1476

2014-12-09 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27693/#review64483 --- The patches may not have been tested before submitting for a review.

Re: Review Request 28793: Patch for KAFKA-1784

2014-12-09 Thread Mayuresh Gharat
> On Dec. 10, 2014, 12:37 a.m., Neha Narkhede wrote: > > Can you add unit tests for this? > > Mayuresh Gharat wrote: > Sure. I will try and add unit tests for this. This part of the code was tested by Clark here, when had encountered an issue where we had to fetch offsets from kafka. - M

Re: Review Request 28793: Patch for KAFKA-1784

2014-12-09 Thread Mayuresh Gharat
> On Dec. 10, 2014, 12:37 a.m., Neha Narkhede wrote: > > Can you add unit tests for this? Sure. I will try and add unit tests for this. - Mayuresh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.or

Re: Review Request 28793: Patch for KAFKA-1784

2014-12-09 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28793/#review64477 --- Can you add unit tests for this? core/src/main/scala/kafka/tools/O

[jira] [Commented] (KAFKA-1816) Topic configs reset after partition increase

2014-12-09 Thread Andrew Jorgensen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14240245#comment-14240245 ] Andrew Jorgensen commented on KAFKA-1816: - I can try this out on 0.8.2 when I get

[jira] [Commented] (KAFKA-1816) Topic configs reset after partition increase

2014-12-09 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14240239#comment-14240239 ] Jay Kreps commented on KAFKA-1816: -- I think we fixed this in 0.8.2 though I don't recall

[jira] [Updated] (KAFKA-1816) Topic configs reset after partition increase

2014-12-09 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1816: - Fix Version/s: 0.8.3 > Topic configs reset after partition increase >

[jira] [Updated] (KAFKA-1816) Topic configs reset after partition increase

2014-12-09 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1816: - Labels: newbie (was: ) > Topic configs reset after partition increase > -

[jira] [Updated] (KAFKA-1816) Topic configs reset after partition increase

2014-12-09 Thread Andrew Jorgensen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Jorgensen updated KAFKA-1816: Description: If you alter a topic to increase the number of partitions then the configurati

[jira] [Created] (KAFKA-1816) Topic configs reset after partition increase

2014-12-09 Thread Andrew Jorgensen (JIRA)
Andrew Jorgensen created KAFKA-1816: --- Summary: Topic configs reset after partition increase Key: KAFKA-1816 URL: https://issues.apache.org/jira/browse/KAFKA-1816 Project: Kafka Issue Type:

[jira] [Commented] (KAFKA-1812) Allow IpV6 in configuration with parseCsvMap

2014-12-09 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14240070#comment-14240070 ] Jeff Holoman commented on KAFKA-1812: - https://reviews.apache.org/r/28859/diff/ > Al

[jira] [Commented] (KAFKA-1810) Add IP Filtering / Whitelists-Blacklists

2014-12-09 Thread Don Bosco Durai (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14239791#comment-14239791 ] Don Bosco Durai commented on KAFKA-1810: [~jholoman], there is a JIRA for supporti

Review Request 28859: Patch for KAFKA-1812

2014-12-09 Thread Jeff Holoman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28859/ --- Review request for kafka. Bugs: KAFKA-1812 https://issues.apache.org/jira/b

[jira] [Updated] (KAFKA-1815) ServerShutdownTest fails in trunk.

2014-12-09 Thread Anatoly Fayngelerin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anatoly Fayngelerin updated KAFKA-1815: --- Status: Patch Available (was: Open) > ServerShutdownTest fails in trunk. > --

[jira] [Updated] (KAFKA-1815) ServerShutdownTest fails in trunk.

2014-12-09 Thread Anatoly Fayngelerin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anatoly Fayngelerin updated KAFKA-1815: --- Attachment: shutdown_test_fix.patch > ServerShutdownTest fails in trunk. > ---

[jira] [Created] (KAFKA-1815) ServerShutdownTest fails in trunk.

2014-12-09 Thread Anatoly Fayngelerin (JIRA)
Anatoly Fayngelerin created KAFKA-1815: -- Summary: ServerShutdownTest fails in trunk. Key: KAFKA-1815 URL: https://issues.apache.org/jira/browse/KAFKA-1815 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-1813) Build fails for scala 2.9.2

2014-12-09 Thread Anatoly Fayngelerin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14239621#comment-14239621 ] Anatoly Fayngelerin commented on KAFKA-1813: Yes. The project was bootstrapped

[jira] [Commented] (KAFKA-1813) Build fails for scala 2.9.2

2014-12-09 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14239567#comment-14239567 ] Joe Stein commented on KAFKA-1813: -- Did you run the new bootstrap we added to the README?

[jira] [Updated] (KAFKA-1813) Build fails for scala 2.9.2

2014-12-09 Thread Anatoly Fayngelerin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anatoly Fayngelerin updated KAFKA-1813: --- Priority: Minor (was: Major) > Build fails for scala 2.9.2 >

[jira] [Created] (KAFKA-1814) FATAL Fatal error during KafkaServerStartable startup. Prepare to shutdown (kafka.server.KafkaServerStartable)

2014-12-09 Thread Stefan (JIRA)
Stefan created KAFKA-1814: -- Summary: FATAL Fatal error during KafkaServerStartable startup. Prepare to shutdown (kafka.server.KafkaServerStartable) Key: KAFKA-1814 URL: https://issues.apache.org/jira/browse/KAFKA-1814

[jira] [Updated] (KAFKA-1813) Build fails for scala 2.9.2

2014-12-09 Thread Anatoly Fayngelerin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anatoly Fayngelerin updated KAFKA-1813: --- Attachment: fix_2_9_2_build.patch patch fixing scala 2.9.2 build > Build fails for sc

[jira] [Updated] (KAFKA-1813) Build fails for scala 2.9.2

2014-12-09 Thread Anatoly Fayngelerin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anatoly Fayngelerin updated KAFKA-1813: --- Status: Patch Available (was: Open) > Build fails for scala 2.9.2 > -

[jira] [Created] (KAFKA-1813) Build fails for scala 2.9.2

2014-12-09 Thread Anatoly Fayngelerin (JIRA)
Anatoly Fayngelerin created KAFKA-1813: -- Summary: Build fails for scala 2.9.2 Key: KAFKA-1813 URL: https://issues.apache.org/jira/browse/KAFKA-1813 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-1646) Improve consumer read performance for Windows

2014-12-09 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14239494#comment-14239494 ] Sriharsha Chintalapani commented on KAFKA-1646: --- [~jkreps] [~junrao] can you