> On Dec. 10, 2014, 5:09 a.m., Jun Rao wrote: > > Haven't looked at your new patch yet. It seems that the following tests > > start to fail after your commit. They seem to pass if run individually, but > > always fail if you run all unit tests. Could you take a look and at least > > understand the cause? > > > > kafka.server.ServerShutdownTest > testCleanShutdown FAILED > > java.lang.NullPointerException > > at > > kafka.server.ServerShutdownTest$$anonfun$verifyNonDaemonThreadsStatus$2.apply(ServerShutdownTest.scala:147) > > at > > kafka.server.ServerShutdownTest$$anonfun$verifyNonDaemonThreadsStatus$2.apply(ServerShutdownTest.scala:147) > > at > > scala.collection.TraversableOnce$$anonfun$count$1.apply(TraversableOnce.scala:114) > > at > > scala.collection.TraversableOnce$$anonfun$count$1.apply(TraversableOnce.scala:113) > > at > > scala.collection.IndexedSeqOptimized$class.foreach(IndexedSeqOptimized.scala:33) > > at > > scala.collection.mutable.ArrayOps$ofRef.foreach(ArrayOps.scala:108) > > at > > scala.collection.TraversableOnce$class.count(TraversableOnce.scala:113) > > at scala.collection.mutable.ArrayOps$ofRef.count(ArrayOps.scala:108) > > at > > kafka.server.ServerShutdownTest.verifyNonDaemonThreadsStatus(ServerShutdownTest.scala:147) > > at > > kafka.server.ServerShutdownTest.testCleanShutdown(ServerShutdownTest.scala:101) > > > > kafka.server.ServerShutdownTest > testConsecutiveShutdown PASSED > > > > kafka.server.ServerShutdownTest > testCleanShutdownWithDeleteTopicEnabled > > FAILED > > java.lang.NullPointerException > > at > > kafka.server.ServerShutdownTest$$anonfun$verifyNonDaemonThreadsStatus$2.apply(ServerShutdownTest.scala:147) > > at > > kafka.server.ServerShutdownTest$$anonfun$verifyNonDaemonThreadsStatus$2.apply(ServerShutdownTest.scala:147) > > at > > scala.collection.TraversableOnce$$anonfun$count$1.apply(TraversableOnce.scala:114) > > at > > scala.collection.TraversableOnce$$anonfun$count$1.apply(TraversableOnce.scala:113) > > at > > scala.collection.IndexedSeqOptimized$class.foreach(IndexedSeqOptimized.scala:33) > > at > > scala.collection.mutable.ArrayOps$ofRef.foreach(ArrayOps.scala:108) > > at > > scala.collection.TraversableOnce$class.count(TraversableOnce.scala:113) > > at scala.collection.mutable.ArrayOps$ofRef.count(ArrayOps.scala:108) > > at > > kafka.server.ServerShutdownTest.verifyNonDaemonThreadsStatus(ServerShutdownTest.scala:147) > > at > > kafka.server.ServerShutdownTest.testCleanShutdownWithDeleteTopicEnabled(ServerShutdownTest.scala:114) > > > > kafka.server.ServerShutdownTest > testCleanShutdownAfterFailedStartup FAILED > > java.lang.NullPointerException > > at > > kafka.server.ServerShutdownTest$$anonfun$verifyNonDaemonThreadsStatus$2.apply(ServerShutdownTest.scala:147) > > at > > kafka.server.ServerShutdownTest$$anonfun$verifyNonDaemonThreadsStatus$2.apply(ServerShutdownTest.scala:147) > > at > > scala.collection.TraversableOnce$$anonfun$count$1.apply(TraversableOnce.scala:114) > > at > > scala.collection.TraversableOnce$$anonfun$count$1.apply(TraversableOnce.scala:113) > > at > > scala.collection.IndexedSeqOptimized$class.foreach(IndexedSeqOptimized.scala:33) > > at > > scala.collection.mutable.ArrayOps$ofRef.foreach(ArrayOps.scala:108) > > at > > scala.collection.TraversableOnce$class.count(TraversableOnce.scala:113) > > at scala.collection.mutable.ArrayOps$ofRef.count(ArrayOps.scala:108) > > at > > kafka.server.ServerShutdownTest.verifyNonDaemonThreadsStatus(ServerShutdownTest.scala:147) > > at > > kafka.server.ServerShutdownTest.testCleanShutdownAfterFailedStartup(ServerShutdownTest.scala:141)
KAFKA-1815 is opened for the failures. It turns out because I forgot to shutdown consumer in ZookeeperConsumerConnector in rebalance listener test. So it causes later on server shutdown test failure. Really sorry for this... I could not reproduce the issue on my desktop probably because it is fast. I actually found that I could reproduce it on my laptop. - Jiangjie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25995/#review64505 ----------------------------------------------------------- On Dec. 8, 2014, 9:36 a.m., Jiangjie Qin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25995/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2014, 9:36 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1650 and KAKFA-1650 > https://issues.apache.org/jira/browse/KAFKA-1650 > https://issues.apache.org/jira/browse/KAKFA-1650 > > > Repository: kafka > > > Description > ------- > > Addressed Guozhang's comments. > > > Addressed Guozhang's comments > > > commit before switch to trunk > > > commit before rebase > > > Rebased on trunk, Addressed Guozhang's comments. > > > Addressed Guozhang's comments on MaxInFlightRequests > > > Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into > mirrormaker-redesign > > > Incorporated Guozhang's comments > > > Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into > mirrormaker-redesign > > > Merged KAFKA-345 into this patch. Incorporated Joel and Jun's comments. > > > Added consumer rebalance listener to mirror maker, will test it later. > > > Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into > mirrormaker-redesign > > Conflicts: > core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala > > core/src/test/scala/unit/kafka/consumer/ZookeeperConsumerConnectorTest.scala > > added custom config for consumer rebalance listener > > > Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into > mirrormaker-redesign > > > Add configurable consumer rebalance listener > > > Incorporated Guozhang's comments > > > Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into > mirrormaker-redesign > > > Incorporated Guozhang's comments. > > > Addressed Guozhang's comment. > > > numMessageUnacked should be decremented no matter the send was successful or > not. > > > Addressed Jun's comments. > > > Incorporated Jun's comments > > > Incorporated Jun's comments and rebased on trunk > > > Diffs > ----- > > core/src/main/scala/kafka/consumer/ConsumerConnector.scala > 62c0686e816d2888772d5a911becf625eedee397 > core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala > e991d2187d03241f639eeaf6769fb59c8c99664c > core/src/main/scala/kafka/javaapi/consumer/ZookeeperConsumerConnector.scala > 9baad34a9793e5067d11289ece2154ba87b388af > core/src/main/scala/kafka/tools/MirrorMaker.scala > b06ff6000183b257005b5ac3ccc7ba8976f1ab8d > > Diff: https://reviews.apache.org/r/25995/diff/ > > > Testing > ------- > > > Thanks, > > Jiangjie Qin > >
