-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28423/
-----------------------------------------------------------

(Updated Dec. 10, 2014, 2:48 a.m.)


Review request for kafka.


Bugs: kafka-1797
    https://issues.apache.org/jira/browse/kafka-1797


Repository: kafka


Description (updated)
-------

add the constructor that takes serializer and seserializer


fix java doc


Diffs (updated)
-----

  
clients/src/main/java/org/apache/kafka/clients/consumer/ByteArrayDeserializer.java
 PRE-CREATION 
  clients/src/main/java/org/apache/kafka/clients/consumer/Consumer.java 
227f5646ee708af1b861c15237eda2140cfd4900 
  clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java 
46efc0c8483acacf42b2984ac3f3b9e0a4566187 
  clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRecord.java 
436d8a479166eda29f2672b50fc99f288bbe3fa9 
  clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRecords.java 
2ecfc8aaea90a7353bd0dabc4c0ebcc6fd9535ec 
  clients/src/main/java/org/apache/kafka/clients/consumer/Deserializer.java 
PRE-CREATION 
  clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java 
fe93afa24fc20b03830f1d190a276041d15bd3b9 
  clients/src/main/java/org/apache/kafka/clients/consumer/MockConsumer.java 
c3aad3b4d6b677f759583f309061193f2f109250 
  
clients/src/main/java/org/apache/kafka/clients/producer/ByteArraySerializer.java
 PRE-CREATION 
  clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java 
32f444ebbd27892275af7a0947b86a6b8317a374 
  clients/src/main/java/org/apache/kafka/clients/producer/MockProducer.java 
c0f1d57e0feb894d9f246058cd0396461afe3225 
  clients/src/main/java/org/apache/kafka/clients/producer/Producer.java 
36e8398416036cab84faad1f07159e5adefd8086 
  clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java 
72d3ddd0c29bf6c08f9e122c8232bc07612cd448 
  clients/src/main/java/org/apache/kafka/clients/producer/ProducerRecord.java 
c3181b368b6cf15e7134b04e8ff5655a9321ee0b 
  clients/src/main/java/org/apache/kafka/clients/producer/Serializer.java 
PRE-CREATION 
  
clients/src/main/java/org/apache/kafka/clients/producer/internals/Partitioner.java
 40e8234f8771098b097bf757a86d5ac98604df5e 
  clients/src/main/java/org/apache/kafka/clients/tools/ProducerPerformance.java 
28175fb71edbe7f090119683b328d6dc4271d9fa 
  
clients/src/main/java/org/apache/kafka/common/errors/DeserializationException.java
 PRE-CREATION 
  
clients/src/main/java/org/apache/kafka/common/errors/SerializationException.java
 PRE-CREATION 
  clients/src/test/java/org/apache/kafka/clients/producer/MockProducerTest.java 
9a9411fc900bfd0669f00557e998dc277e65e6c9 
  clients/src/test/java/org/apache/kafka/clients/producer/PartitionerTest.java 
f06e28ce21e80c1265258ad3ac7900b99e61493d 
  core/src/main/scala/kafka/producer/BaseProducer.scala 
b0207930dd0543f2c51f0b35002e13bf104340ff 
  core/src/main/scala/kafka/producer/KafkaLog4jAppender.scala 
4b5b823b85477394cd50eb2a66877a3b8b35b57f 
  core/src/main/scala/kafka/tools/MirrorMaker.scala 
b06ff6000183b257005b5ac3ccc7ba8976f1ab8d 
  core/src/main/scala/kafka/tools/ReplayLogProducer.scala 
3393a3dd574ac45a27bf7eda646b737146c55038 
  core/src/main/scala/kafka/tools/TestEndToEndLatency.scala 
67196f30af1cfcd40ded20ca970082b78504f6af 
  core/src/main/scala/kafka/tools/TestLogCleaning.scala 
1d4ea93f2ba8d4d4d47a307cd47f54a15d3d30dd 
  core/src/test/scala/integration/kafka/api/ProducerCompressionTest.scala 
6379f2b60af797b084981c94fd84b3d7740aa8a5 
  core/src/test/scala/integration/kafka/api/ProducerFailureHandlingTest.scala 
a913fe59ba6f7c86a48e264ff85158a345b4e9e4 
  core/src/test/scala/integration/kafka/api/ProducerSendTest.scala 
d407af9144ef6930d737a6dcf23591c1f6342f87 
  core/src/test/scala/unit/kafka/utils/TestUtils.scala 
0da774d0ed015bdc0461b854e3540ee6e48d1838 

Diff: https://reviews.apache.org/r/28423/diff/


Testing
-------


Thanks,

Jun Rao

Reply via email to