> On Dec. 10, 2014, 12:37 a.m., Neha Narkhede wrote: > > Can you add unit tests for this? > > Mayuresh Gharat wrote: > Sure. I will try and add unit tests for this.
This part of the code was tested by Clark here, when had encountered an issue where we had to fetch offsets from kafka. - Mayuresh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28793/#review64477 ----------------------------------------------------------- On Dec. 7, 2014, 7:43 p.m., Mayuresh Gharat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28793/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2014, 7:43 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1784 > https://issues.apache.org/jira/browse/KAFKA-1784 > > > Repository: kafka > > > Description > ------- > > Offset Client for fetching and commiting offsets to kafka > > > Diffs > ----- > > core/src/main/scala/kafka/tools/OffsetClient.scala PRE-CREATION > core/src/main/scala/kafka/tools/OffsetClientConfig.scala PRE-CREATION > > Diff: https://reviews.apache.org/r/28793/diff/ > > > Testing > ------- > > > Thanks, > > Mayuresh Gharat > >
