Re: Review Request 19696: Patch for KAFKA-1317

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19696/#review38870 --- core/src/test/scala/unit/kafka/log4j/KafkaLog4jAppenderTest.scala <

[jira] [Updated] (KAFKA-1323) log.dirs server property no longer supports relative directories

[ https://issues.apache.org/jira/browse/KAFKA-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1323: - Attachment: kafka-1323-trunk-test-failures.png I ran into quite a few unit test failures with the

[jira] [Closed] (KAFKA-1251) Add metrics to the producer

[ https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede closed KAFKA-1251. > Add metrics to the producer > --- > > Key: KAFKA-1251 >

[jira] [Resolved] (KAFKA-1251) Add metrics to the producer

[ https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps resolved KAFKA-1251. -- Resolution: Fixed > Add metrics to the producer > --- > > Key:

[jira] [Commented] (KAFKA-1251) Add metrics to the producer

[ https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950336#comment-13950336 ] Neha Narkhede commented on KAFKA-1251: -- Sounds good, thanks Jay! I'm a +1 on the late

Re: Review Request 19771: Patch for KAFKA-1251

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19771/#review38867 --- Ship it! LGTM clients/src/main/java/org/apache/kafka/clients/prod

Re: Review Request 19770: Patch for KAFKA-1251

> On March 28, 2014, 3:50 a.m., Neha Narkhede wrote: > > Ship It! Could you file a follow up JIRA to look into the "node--1" per node metrics issue? It will be nice to fix it at some point, though I think we don't have to block the checkin of this patch on that. - Neha

[jira] [Commented] (KAFKA-1251) Add metrics to the producer

[ https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950333#comment-13950333 ] Jay Kreps commented on KAFKA-1251: -- Created reviewboard https://reviews.apache.org/r/1977

[jira] [Updated] (KAFKA-1251) Add metrics to the producer

[ https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-1251: - Attachment: KAFKA-1251.patch > Add metrics to the producer > --- > >

Re: Review Request 19770: Patch for KAFKA-1251

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19770/#review38865 --- Ship it! Ship It! clients/src/main/java/org/apache/kafka/clients/

Review Request 19771: Patch for KAFKA-1251

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19771/ --- Review request for kafka. Bugs: KAFKA-1251 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-1251) Add metrics to the producer

[ https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950332#comment-13950332 ] Jay Kreps commented on KAFKA-1251: -- Okay I addressed most of the concerns people raised.

[jira] [Commented] (KAFKA-1251) Add metrics to the producer

[ https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950328#comment-13950328 ] Jay Kreps commented on KAFKA-1251: -- Created reviewboard https://reviews.apache.org/r/1977

[jira] [Updated] (KAFKA-1251) Add metrics to the producer

[ https://issues.apache.org/jira/browse/KAFKA-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-1251: - Attachment: KAFKA-1251.patch > Add metrics to the producer > --- > >

Review Request 19770: Patch for KAFKA-1251

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19770/ --- Review request for kafka. Bugs: KAFKA-1251 https://issues.apache.org/jira/b

[jira] [Commented] (KAFKA-1345) java API to shutdown the connector by using a consumergroup id

[ https://issues.apache.org/jira/browse/KAFKA-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950323#comment-13950323 ] Neha Narkhede commented on KAFKA-1345: -- I'm not so sure I understood that. What do yo

[jira] [Created] (KAFKA-1346) Revisit sample start date in metrics under when there is no activity

Jay Kreps created KAFKA-1346: Summary: Revisit sample start date in metrics under when there is no activity Key: KAFKA-1346 URL: https://issues.apache.org/jira/browse/KAFKA-1346 Project: Kafka I

[jira] [Assigned] (KAFKA-1346) Revisit sample start date in metrics under when there is no activity

[ https://issues.apache.org/jira/browse/KAFKA-1346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps reassigned KAFKA-1346: Assignee: Jay Kreps > Revisit sample start date in metrics under when there is no activity > --

[jira] [Created] (KAFKA-1345) java API to shutdown the connector by using a consumergroup id

schandr created KAFKA-1345: -- Summary: java API to shutdown the connector by using a consumergroup id Key: KAFKA-1345 URL: https://issues.apache.org/jira/browse/KAFKA-1345 Project: Kafka Issue Type:

[jira] [Comment Edited] (KAFKA-1343) Kafka consumer iterator thread stalls

[ https://issues.apache.org/jira/browse/KAFKA-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950256#comment-13950256 ] schandr edited comment on KAFKA-1343 at 3/28/14 1:47 AM: - Thanks f

[jira] [Updated] (KAFKA-1343) Kafka consumer iterator thread stalls

[ https://issues.apache.org/jira/browse/KAFKA-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] schandr updated KAFKA-1343: --- Attachment: producerscreenshot.jpg > Kafka consumer iterator thread stalls >

[jira] [Commented] (KAFKA-1343) Kafka consumer iterator thread stalls

[ https://issues.apache.org/jira/browse/KAFKA-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950256#comment-13950256 ] schandr commented on KAFKA-1343: Thanks for pointing me to the above link. The kafka.tool

[jira] [Commented] (KAFKA-1323) log.dirs server property no longer supports relative directories

[ https://issues.apache.org/jira/browse/KAFKA-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950112#comment-13950112 ] Timothy Chen commented on KAFKA-1323: - Updated reviewboard https://reviews.apache.org/

[jira] [Updated] (KAFKA-1323) log.dirs server property no longer supports relative directories

[ https://issues.apache.org/jira/browse/KAFKA-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated KAFKA-1323: Attachment: KAFKA-1323_2014-03-27_16:17:26.patch > log.dirs server property no longer supports rela

Re: Review Request 19626: Patch for KAFKA-1323

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19626/ --- (Updated March 27, 2014, 11:17 p.m.) Review request for kafka. Bugs: KAFKA-13

Re: Review Request 19388: Patch for KAFKA-1251

> On March 27, 2014, 4:59 p.m., Guozhang Wang wrote: > > clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java, > > line 116 > > > > > > They ready() function is a little bit heavy,

[jira] [Updated] (KAFKA-1317) KafkaServer 0.8.1 not responding to .shutdown() cleanly, possibly related to TopicDeletionManager or MetricsMeter state

[ https://issues.apache.org/jira/browse/KAFKA-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated KAFKA-1317: Attachment: KAFKA-1317_2014-03-27_15:15:05.patch > KafkaServer 0.8.1 not responding to .shutdown()

[jira] [Commented] (KAFKA-1317) KafkaServer 0.8.1 not responding to .shutdown() cleanly, possibly related to TopicDeletionManager or MetricsMeter state

[ https://issues.apache.org/jira/browse/KAFKA-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950016#comment-13950016 ] Timothy Chen commented on KAFKA-1317: - Updated reviewboard https://reviews.apache.org/

Re: Review Request 19696: Patch for KAFKA-1317

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19696/ --- (Updated March 27, 2014, 10:15 p.m.) Review request for kafka. Bugs: KAFKA-13

[jira] [Commented] (KAFKA-1341) Client Selector doesn't check connection id properly

[ https://issues.apache.org/jira/browse/KAFKA-1341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13949813#comment-13949813 ] Jay Kreps commented on KAFKA-1341: -- I'm +1, though is the change in scala version in the

[jira] Subscription: outstanding kafka patches

Issue Subscription Filter: outstanding kafka patches (84 issues) The list of outstanding kafka patches Subscriber: kafka-mailing-list Key Summary KAFKA-1341 Client Selector doesn't check connection id properly https://issues.apache.org/jira/browse/KAFKA-1341 KAFKA-1324 Debian

[jira] [Updated] (KAFKA-1124) Sending to a new topic (with auto.create.topics.enable) returns ERROR

[ https://issues.apache.org/jira/browse/KAFKA-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1124: - Labels: usability (was: ) > Sending to a new topic (with auto.create.topics.enable) returns ERRO

[jira] [Commented] (KAFKA-1124) Sending to a new topic (with auto.create.topics.enable) returns ERROR

[ https://issues.apache.org/jira/browse/KAFKA-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13949732#comment-13949732 ] Robin Yamaguchi commented on KAFKA-1124: I'm running 0.8.1. and only run into this

[jira] [Updated] (KAFKA-1193) Data loss if broker is killed using kill -9

[ https://issues.apache.org/jira/browse/KAFKA-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1193: - Assignee: (was: Neha Narkhede) > Data loss if broker is killed using kill -9 > --

[jira] [Updated] (KAFKA-1193) Data loss if broker is killed using kill -9

[ https://issues.apache.org/jira/browse/KAFKA-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1193: - Fix Version/s: 0.8.2 > Data loss if broker is killed using kill -9 >

Re: Review Request 19388: Patch for KAFKA-1251

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19388/#review38748 --- Could you rebase? clients/src/main/java/org/apache/kafka/clients/p

[jira] [Commented] (KAFKA-1343) Kafka consumer iterator thread stalls

[ https://issues.apache.org/jira/browse/KAFKA-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13949521#comment-13949521 ] Guozhang Wang commented on KAFKA-1343: -- Does this help trouble shooting your problem?

[jira] [Commented] (KAFKA-1328) Add new consumer APIs

[ https://issues.apache.org/jira/browse/KAFKA-1328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13949510#comment-13949510 ] Neha Narkhede commented on KAFKA-1328: -- Javadoc is here - http://people.apache.org/~

[jira] [Work started] (KAFKA-1328) Add new consumer APIs

[ https://issues.apache.org/jira/browse/KAFKA-1328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-1328 started by Neha Narkhede. > Add new consumer APIs > - > > Key: KAFKA-1328 > URL: https://issues.apa

[jira] [Commented] (KAFKA-1328) Add new consumer APIs

[ https://issues.apache.org/jira/browse/KAFKA-1328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13949504#comment-13949504 ] Neha Narkhede commented on KAFKA-1328: -- Created reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1328) Add new consumer APIs

[ https://issues.apache.org/jira/browse/KAFKA-1328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1328: - Attachment: KAFKA-1328.patch > Add new consumer APIs > - > >

Review Request 19731: Patch for KAFKA-1328

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19731/ --- Review request for kafka. Bugs: KAFKA-1328 https://issues.apache.org/jira/b

Re: New Consumer API discussion

If people don't have any more thoughts on this, I will go ahead and submit a reviewboard to https://issues.apache.org/jira/browse/KAFKA-1328. Thanks, Neha On Mon, Mar 24, 2014 at 5:39 PM, Neha Narkhede wrote: > I took some time to write some example code using the new consumer APIs to > cover a

[jira] [Updated] (KAFKA-1328) Add new consumer APIs

[ https://issues.apache.org/jira/browse/KAFKA-1328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1328: - Summary: Add new consumer APIs (was: Add new consumer APIs and configs) > Add new consumer APIs

[jira] [Updated] (KAFKA-1344) Kafka-console-producer.sh support snappy compression

[ https://issues.apache.org/jira/browse/KAFKA-1344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1344: - Fix Version/s: 0.8.2 > Kafka-console-producer.sh support snappy compression > ---

[jira] [Updated] (KAFKA-1344) Kafka-console-producer.sh support snappy compression

[ https://issues.apache.org/jira/browse/KAFKA-1344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1344: - Labels: tools usability (was: ) > Kafka-console-producer.sh support snappy compression > ---

[jira] [Created] (KAFKA-1344) Kafka-console-producer.sh support snappy compression

aio created KAFKA-1344: -- Summary: Kafka-console-producer.sh support snappy compression Key: KAFKA-1344 URL: https://issues.apache.org/jira/browse/KAFKA-1344 Project: Kafka Issue Type: Improvement

[jira] [Commented] (KAFKA-1341) Client Selector doesn't check connection id properly

[ https://issues.apache.org/jira/browse/KAFKA-1341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13949238#comment-13949238 ] Neha Narkhede commented on KAFKA-1341: -- +1, LGTM. [~jkreps], would you like to take a

Re: Review Request 19690: Patch for KAFKA-1341

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19690/#review38723 --- Ship it! Ship It! - Neha Narkhede On March 26, 2014, 5:55 p.m.,

[jira] [Updated] (KAFKA-1341) Client Selector doesn't check connection id properly

[ https://issues.apache.org/jira/browse/KAFKA-1341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1341: - Component/s: producer > Client Selector doesn't check connection id properly > -

[jira] [Updated] (KAFKA-1342) Slow controlled shutdowns can result in stale shutdown requests

[ https://issues.apache.org/jira/browse/KAFKA-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1342: - Fix Version/s: 0.8.1.1 > Slow controlled shutdowns can result in stale shutdown requests > --

[jira] [Updated] (KAFKA-1342) Slow controlled shutdowns can result in stale shutdown requests

[ https://issues.apache.org/jira/browse/KAFKA-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1342: - Priority: Blocker (was: Major) > Slow controlled shutdowns can result in stale shutdown requests

[jira] [Commented] (KAFKA-1193) Data loss if broker is killed using kill -9

[ https://issues.apache.org/jira/browse/KAFKA-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13949212#comment-13949212 ] Neha Narkhede commented on KAFKA-1193: -- [~hanish.bansal.agarwal] Would you mind repea

[jira] [Created] (KAFKA-1343) Kafka consumer iterator thread stalls

schandr created KAFKA-1343: -- Summary: Kafka consumer iterator thread stalls Key: KAFKA-1343 URL: https://issues.apache.org/jira/browse/KAFKA-1343 Project: Kafka Issue Type: Bug Reporter: