----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19771/#review38867 -----------------------------------------------------------
Ship it! LGTM clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordBatch.java <https://reviews.apache.org/r/19771/#comment71200> Could you address this merge error on checkin? - Neha Narkhede On March 28, 2014, 3:48 a.m., Jay Kreps wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19771/ > ----------------------------------------------------------- > > (Updated March 28, 2014, 3:48 a.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1251 > https://issues.apache.org/jira/browse/KAFKA-1251 > > > Repository: kafka > > > Description > ------- > > KAFKA-1251: Add metrics to the producer. > > > Diffs > ----- > > clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java > 1ff9174870a8c9cd97eb6655416edd4124377b0e > clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java > 48706baa5eeee2f9c29e2fec7a81bb090ddd21ae > > clients/src/main/java/org/apache/kafka/clients/producer/internals/FutureRecordMetadata.java > aec31c381658f85ab6394a6475b4989177a31a3d > > clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java > 50bf95feab93a42c20ccef9299348dfd37728f11 > > clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordBatch.java > 35f1d7a6c5b9021d48c22231769664e7e25d6c52 > > clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java > 565331dfb9cd1d65be37ed97830aa42e44d2e127 > > clients/src/main/java/org/apache/kafka/clients/tools/ProducerPerformance.java > 05085e02705c59c5fb5bd19d05c5baa88bfc0af8 > clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java > 6db2dfbe94c940efa37463298f0b0b1893e646e1 > clients/src/main/java/org/apache/kafka/common/metrics/Sensor.java > 7e4849b7a148009c8a878349d7f0239108ccad8c > > clients/src/main/java/org/apache/kafka/common/metrics/stats/Percentiles.java > 4d549167ea7c1390ecf1440e40332375f247088f > clients/src/main/java/org/apache/kafka/common/metrics/stats/Rate.java > 3b0454f26490d1f4a2a80efb00165fc72587fbf8 > > clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java > f8b413a8c273cdad56177fbc6971fece4feb86b3 > clients/src/main/java/org/apache/kafka/common/network/ByteBufferSend.java > 9305b61ddeaa2bb400cbbb6d3c99c8ecaade6b8f > clients/src/main/java/org/apache/kafka/common/network/NetworkReceive.java > 51d4892dfc18580e5e213d386c5de387a47d3c6b > clients/src/main/java/org/apache/kafka/common/network/Selector.java > 983963200ce81614577cd6182a5d2f10c22b95d4 > clients/src/main/java/org/apache/kafka/common/utils/CopyOnWriteMap.java > 187d22fba5fe225546738fbf43b25fa9e5b4f334 > clients/src/test/java/org/apache/kafka/clients/producer/MetadataTest.java > 09a5355d25a3b94c8e23caa2adc77cb1c59368b9 > > clients/src/test/java/org/apache/kafka/clients/producer/RecordAccumulatorTest.java > ed5690641a22fbe4bd91b0c6055d465944b08c06 > clients/src/test/java/org/apache/kafka/clients/producer/SenderTest.java > 12c9500ce4387306ab5aa7a5781b4aca52b86604 > clients/src/test/java/org/apache/kafka/common/metrics/MetricsTest.java > fdd89141579b6ab2bfaf2b1588440909ae0a7bfd > clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java > 90e2dcf5434db546387302fb0219edfdb363592e > clients/src/test/java/org/apache/kafka/test/MetricsBench.java > 7239b4a56e93f019e66aa2cf2aa9b04c26908bfd > clients/src/test/java/org/apache/kafka/test/Microbenchmarks.java > 46cf86e67e5ee3a8bc841b1d66897862fe1233cf > config/log4j.properties baa698b64259b18efed372cf009a04613b6c53cf > > Diff: https://reviews.apache.org/r/19771/diff/ > > > Testing > ------- > > > Thanks, > > Jay Kreps > >
