----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19696/#review38870 -----------------------------------------------------------
core/src/test/scala/unit/kafka/log4j/KafkaLog4jAppenderTest.scala <https://reviews.apache.org/r/19696/#comment71202> We avoid sleeping for a certain time in our unit tests to prevent transient failures. Instead, you can wait on the message being written to the leader's log. For an example, look at how waitUntilTrue() is used in rest of our tests. - Neha Narkhede On March 27, 2014, 10:15 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19696/ > ----------------------------------------------------------- > > (Updated March 27, 2014, 10:15 p.m.) > > > Review request for kafka. > > > Bugs: KAFKA-1317 > https://issues.apache.org/jira/browse/KAFKA-1317 > > > Repository: kafka > > > Description > ------- > > KAFKA-1317 Fix Kafka shutdown with delete topic on > > > Diffs > ----- > > core/src/main/scala/kafka/controller/KafkaController.scala > 7dc27186dec23eccef934b0a1af9f320553e6c7c > core/src/main/scala/kafka/controller/TopicDeletionManager.scala > 488dfd08d9956dab2fb1ed3925d138cda637509d > core/src/test/scala/unit/kafka/log4j/KafkaLog4jAppenderTest.scala > 67497dd042dfd4ad54875fe29200d67f59137264 > core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala > b5936d4101b513baa805ab26361fe965bdf980aa > core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala > 20fe93e623319fd82236eb6364d7f80bf7a256aa > core/src/test/scala/unit/kafka/utils/TestUtils.scala > 2054c25bbced6bd90c092a1974975732ad346146 > > Diff: https://reviews.apache.org/r/19696/diff/ > > > Testing > ------- > > > Thanks, > > Timothy Chen > >
