YYTVicky commented on pull request #14:
URL: https://github.com/apache/jspwiki/pull/14#issuecomment-621545842
Hi,
I am not sure why the PR does not pass the test, I try to leave a comment
in your file to avoid the test fail issues. But since SHA1 is a broken hash
algorithm, would yo
arturobernalg opened a new pull request #15:
URL: https://github.com/apache/jspwiki/pull/15
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
arturobernalg commented on pull request #15:
URL: https://github.com/apache/jspwiki/pull/15#issuecomment-739476822
Add commit with some fix in the javadoc
This is an automated message from the Apache Git Service.
To respond
arturobernalg opened a new pull request #16:
URL: https://github.com/apache/jspwiki/pull/16
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
juanpablo-santos closed pull request #14:
URL: https://github.com/apache/jspwiki/pull/14
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
juanpablo-santos commented on pull request #14:
URL: https://github.com/apache/jspwiki/pull/14#issuecomment-745550729
Hi,
apologies for the long time without notice
as discussed on the dev ML, this PR is more about a feature request than a
contribution, hence we're going to cl
juanpablo-santos commented on a change in pull request #15:
URL: https://github.com/apache/jspwiki/pull/15#discussion_r545343859
##
File path: .github/dependabot.yml
##
@@ -0,0 +1,25 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license
juanpablo-santos merged pull request #16:
URL: https://github.com/apache/jspwiki/pull/16
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
juanpablo-santos commented on pull request #16:
URL: https://github.com/apache/jspwiki/pull/16#issuecomment-747648792
PR merged, thanks for the contribution, @arturobernalg!
This is an automated message from the Apache Git Se
arturobernalg commented on a change in pull request #15:
URL: https://github.com/apache/jspwiki/pull/15#discussion_r545582681
##
File path: .github/dependabot.yml
##
@@ -0,0 +1,25 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license ag
arturobernalg opened a new pull request #17:
URL: https://github.com/apache/jspwiki/pull/17
* Replace "ISO-8859-1" for StandardCharsets.ISO_8859_1
* Unnecessary semicolon ''
* add final
* Unnecessary 'null' check before 'equals()' call
-
arturobernalg commented on pull request #17:
URL: https://github.com/apache/jspwiki/pull/17#issuecomment-748199608
Hi @juanpablo-santos
I'm really sorry the number of line. but i thing the change proposed it
will improve the code
Pls let me know if you want me to change somethin
arturobernalg edited a comment on pull request #17:
URL: https://github.com/apache/jspwiki/pull/17#issuecomment-748199608
Hi @juanpablo-santos
I'm very sorry for the line number and files changed. but i thing the change
proposed it will improve the code
Pls let me know if you wan
juanpablo-santos commented on a change in pull request #15:
URL: https://github.com/apache/jspwiki/pull/15#discussion_r546411406
##
File path: .github/dependabot.yml
##
@@ -0,0 +1,25 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license
arturobernalg commented on a change in pull request #15:
URL: https://github.com/apache/jspwiki/pull/15#discussion_r546417545
##
File path: .github/dependabot.yml
##
@@ -0,0 +1,25 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license ag
arturobernalg commented on a change in pull request #15:
URL: https://github.com/apache/jspwiki/pull/15#discussion_r546417545
##
File path: .github/dependabot.yml
##
@@ -0,0 +1,25 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license ag
arturobernalg commented on a change in pull request #15:
URL: https://github.com/apache/jspwiki/pull/15#discussion_r547233969
##
File path: .github/dependabot.yml
##
@@ -0,0 +1,25 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license ag
arturobernalg commented on a change in pull request #15:
URL: https://github.com/apache/jspwiki/pull/15#discussion_r547233969
##
File path: .github/dependabot.yml
##
@@ -0,0 +1,25 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license ag
arturobernalg commented on a change in pull request #15:
URL: https://github.com/apache/jspwiki/pull/15#discussion_r548108639
##
File path: .github/dependabot.yml
##
@@ -0,0 +1,25 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license ag
juanpablo-santos commented on a change in pull request #15:
URL: https://github.com/apache/jspwiki/pull/15#discussion_r548192748
##
File path: .github/dependabot.yml
##
@@ -0,0 +1,25 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license
juanpablo-santos commented on a change in pull request #15:
URL: https://github.com/apache/jspwiki/pull/15#discussion_r548192748
##
File path: .github/dependabot.yml
##
@@ -0,0 +1,25 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license
juanpablo-santos merged pull request #17:
URL: https://github.com/apache/jspwiki/pull/17
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
arturobernalg commented on a change in pull request #15:
URL: https://github.com/apache/jspwiki/pull/15#discussion_r548201736
##
File path: .github/dependabot.yml
##
@@ -0,0 +1,25 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license ag
juanpablo-santos commented on a change in pull request #15:
URL: https://github.com/apache/jspwiki/pull/15#discussion_r548207846
##
File path: .github/dependabot.yml
##
@@ -0,0 +1,25 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license
arturobernalg commented on a change in pull request #15:
URL: https://github.com/apache/jspwiki/pull/15#discussion_r548212700
##
File path: .github/dependabot.yml
##
@@ -0,0 +1,25 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license ag
juanpablo-santos merged pull request #15:
URL: https://github.com/apache/jspwiki/pull/15
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
dependabot[bot] opened a new pull request #18:
URL: https://github.com/apache/jspwiki/pull/18
Bumps apache-rat-plugin from 0.11 to 0.13.
[
from 3.0.0 to 3.1.1.
Commits
https://github.com/apache/maven-project-info-repor
dependabot[bot] opened a new pull request #20:
URL: https://github.com/apache/jspwiki/pull/20
Bumps
[checksum-maven-plugin](https://github.com/nicoulaj/checksum-maven-plugin) from
1.8 to 1.9.
Commits
https://github.com/nicoulaj/checksum-maven-plugin/commit/4f42d5b1bed4c55bf08
dependabot[bot] opened a new pull request #22:
URL: https://github.com/apache/jspwiki/pull/22
Bumps [wro4j-maven-plugin](https://github.com/wro4j/wro4j) from 1.8.0 to
1.10.1.
Release notes
Sourced from https://github.com/wro4j/wro4j/releases";>wro4j-maven-plugin's
releases.
dependabot[bot] opened a new pull request #21:
URL: https://github.com/apache/jspwiki/pull/21
Bumps [javax.servlet.jsp-api](https://github.com/javaee/javaee-jsp-api) from
2.3.0 to 2.3.3.
Commits
https://github.com/javaee/javaee-jsp-api/commit/80b323bd9a751b8e09592aaede676ce851
juanpablo-santos closed pull request #18:
URL: https://github.com/apache/jspwiki/pull/18
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
dependabot[bot] commented on pull request #18:
URL: https://github.com/apache/jspwiki/pull/18#issuecomment-753373606
OK, I won't notify you again about this release, but will get in touch when
a new version is available.
If you change your mind, just re-open this PR and I'll resolve
dependabot[bot] opened a new pull request #23:
URL: https://github.com/apache/jspwiki/pull/23
Bumps
[jspc-maven-plugin](https://github.com/leonardehrenfried/jspc-maven-plugin)
from 3.1.0 to 3.2.0.
Release notes
Sourced from https://github.com/leonardehrenfried/jspc-maven-plugin/r
juanpablo-santos merged pull request #22:
URL: https://github.com/apache/jspwiki/pull/22
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
dependabot[bot] opened a new pull request #24:
URL: https://github.com/apache/jspwiki/pull/24
Bumps
[maven-assembly-plugin](https://github.com/apache/maven-assembly-plugin) from
3.2.0 to 3.3.0.
Commits
https://github.com/apache/maven-assembly-plugin/commit/5a48193bc2de65428c0
juanpablo-santos merged pull request #19:
URL: https://github.com/apache/jspwiki/pull/19
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
dependabot[bot] opened a new pull request #25:
URL: https://github.com/apache/jspwiki/pull/25
Bumps [xstream](https://github.com/x-stream/xstream) from 1.4.13 to 1.4.15.
Commits
See full diff in https://github.com/x-stream/xstream/commits";>compare view
[
juanpablo-santos merged pull request #20:
URL: https://github.com/apache/jspwiki/pull/20
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
dependabot[bot] opened a new pull request #26:
URL: https://github.com/apache/jspwiki/pull/26
Bumps [maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin)
from 3.1.1 to 3.2.0.
Commits
https://github.com/apache/maven-javadoc-plugin/commit/d3b77d6e1bbd079a0d5d065
juanpablo-santos merged pull request #21:
URL: https://github.com/apache/jspwiki/pull/21
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
dependabot[bot] opened a new pull request #27:
URL: https://github.com/apache/jspwiki/pull/27
Bumps jetty-all from 8.1.15.v20140411 to 9.2.30.v20200428.
[
from 3.2.0 to 4.0.0.
Commits
https://github.com/leonardehrenfried/jspc-maven-plugin/commit/4ac147a23
dependabot[bot] opened a new pull request #29:
URL: https://github.com/apache/jspwiki/pull/29
Bumps [selenide](https://github.com/selenide/selenide) from 5.16.2 to 5.17.2.
Release notes
Sourced from https://github.com/selenide/selenide/releases";>selenide's
releases.
v5.17.
juanpablo-santos closed pull request #30:
URL: https://github.com/apache/jspwiki/pull/30
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
dependabot[bot] commented on pull request #30:
URL: https://github.com/apache/jspwiki/pull/30#issuecomment-754140601
OK, I won't notify you again about this release, but will get in touch when
a new version is available.
If you change your mind, just re-open this PR and I'll resolve
juanpablo-santos merged pull request #28:
URL: https://github.com/apache/jspwiki/pull/28
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
juanpablo-santos merged pull request #29:
URL: https://github.com/apache/jspwiki/pull/29
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
dependabot[bot] opened a new pull request #31:
URL: https://github.com/apache/jspwiki/pull/31
Bumps `mockito.version` from 3.6.28 to 3.7.0.
Updates `mockito-core` from 3.6.28 to 3.7.0
Release notes
Sourced from https://github.com/mockito/mockito/releases";>mockito-core's
releas
arturobernalg opened a new pull request #32:
URL: https://github.com/apache/jspwiki/pull/32
* Remove redundant initializer
* Redundant interface modifier --> Not really performance
* Remove Unused import
* Bulk operation can be used instead of iteration
* Manual array copy
* M
juanpablo-santos merged pull request #32:
URL: https://github.com/apache/jspwiki/pull/32
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
dependabot[bot] opened a new pull request #34:
URL: https://github.com/apache/jspwiki/pull/34
Bumps
[sonar-maven-plugin](https://github.com/SonarSource/sonar-scanner-maven) from
3.7.0.1746 to 3.8.0.2131.
Commits
https://github.com/SonarSource/sonar-scanner-maven/commit/f40ccf
dependabot[bot] opened a new pull request #33:
URL: https://github.com/apache/jspwiki/pull/33
Bumps [selenide](https://github.com/selenide/selenide) from 5.17.3 to 5.17.4.
Changelog
Sourced from https://github.com/selenide/selenide/blob/master/CHANGELOG.md";>selenide's
changelog.
dependabot[bot] opened a new pull request #35:
URL: https://github.com/apache/jspwiki/pull/35
Bumps `mockito.version` from 3.6.28 to 3.7.7.
Updates `mockito-core` from 3.6.28 to 3.7.7
Release notes
Sourced from https://github.com/mockito/mockito/releases";>mockito-core's
releas
dependabot[bot] closed pull request #31:
URL: https://github.com/apache/jspwiki/pull/31
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
dependabot[bot] commented on pull request #31:
URL: https://github.com/apache/jspwiki/pull/31#issuecomment-762071892
Superseded by #35.
This is an automated message from the Apache Git Service.
To respond to the message, plea
arturobernalg opened a new pull request #36:
URL: https://github.com/apache/jspwiki/pull/36
* Add final on private variable --> just try to make all class/var read-only
* Remove Redundant initializer
* Use isEmpty() instead length()
* Avoid use pre-size array
-
dependabot[bot] opened a new pull request #37:
URL: https://github.com/apache/jspwiki/pull/37
Bumps jetty-all from 9.4.35.v20201120 to 9.4.36.v20210114.
[ from 5.17.3 to 5.18.0.
Changelog
Sourced from https://github.com/selenide/selenide/blob/master/CHANGELOG.md";>selenide's
changelog.
dependabot[bot] commented on pull request #33:
URL: https://github.com/apache/jspwiki/pull/33#issuecomment-766625121
Superseded by #38.
This is an automated message from the Apache Git Service.
To respond to the message, plea
dependabot[bot] closed pull request #33:
URL: https://github.com/apache/jspwiki/pull/33
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
dependabot[bot] opened a new pull request #39:
URL: https://github.com/apache/jspwiki/pull/39
Bumps cargo-maven2-plugin from 1.8.4 to 1.8.5.
[ from 5.17.3 to 5.18.1.
Release notes
Sourced from https://github.com/selenide/selenide/releases";>selenide's
releases.
v5.18.
dependabot[bot] closed pull request #37:
URL: https://github.com/apache/jspwiki/pull/37
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
dependabot[bot] commented on pull request #37:
URL: https://github.com/apache/jspwiki/pull/37#issuecomment-783951112
Superseded by #41.
This is an automated message from the Apache Git Service.
To respond to the message, plea
dependabot[bot] opened a new pull request #41:
URL: https://github.com/apache/jspwiki/pull/41
Bumps jetty-all from 9.4.35.v20201120 to 9.4.37.v20210219.
[ from 5.17.3 to 5.19.0.
Release notes
Sourced from https://github.com/selenide/selenide/releases";>selenide's
releases.
v5.19.
dependabot[bot] closed pull request #40:
URL: https://github.com/apache/jspwiki/pull/40
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
takalat opened a new pull request #43:
URL: https://github.com/apache/jspwiki/pull/43
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
takalat closed pull request #43:
URL: https://github.com/apache/jspwiki/pull/43
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
takalat opened a new pull request #44:
URL: https://github.com/apache/jspwiki/pull/44
Cookies are now being asked until accepted.
Further discussion:
- External cookies which are not system required should be parsed in other
way to effectively use cookie-policy.
- Cookie lifeti
dependabot[bot] closed pull request #41:
URL: https://github.com/apache/jspwiki/pull/41
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
dependabot[bot] opened a new pull request #45:
URL: https://github.com/apache/jspwiki/pull/45
Bumps jetty-all from 9.4.35.v20201120 to 9.4.38.v20210224.
[.
Since we have a lot of documents in our Wiki, it
takalat commented on a change in pull request #44:
URL: https://github.com/apache/jspwiki/pull/44#discussion_r585901733
##
File path: jspwiki-war/src/main/webapp/templates/default/commonheader.jsp
##
@@ -156,4 +177,76 @@ String.I18N.PREFIX = "javascript.";
src="" >
takalat commented on a change in pull request #44:
URL: https://github.com/apache/jspwiki/pull/44#discussion_r585901825
##
File path:
jspwiki-main/src/main/java/org/apache/wiki/preferences/Preferences.java
##
@@ -125,19 +133,21 @@ public static void reloadPreferences( final Pa
brushed commented on pull request #44:
URL: https://github.com/apache/jspwiki/pull/44#issuecomment-791912513
Looking at the proposed patch, I'm not in favor of taking this into the
code base.
How does the current JSPWiki Cookie notification work :
In the LeftMenu page,
juanpablo-santos commented on pull request #44:
URL: https://github.com/apache/jspwiki/pull/44#issuecomment-792273694
Hi @brushed ,
thanks for the detailed response! Given that I think we can close both
JSPWIKI-1117 and JSPWIKI-1147 with "Won't fix".
@takalat since you seem t
juanpablo-santos closed pull request #44:
URL: https://github.com/apache/jspwiki/pull/44
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
juanpablo-santos commented on pull request #44:
URL: https://github.com/apache/jspwiki/pull/44#issuecomment-792357329
closed JSPWIKI-1117 with won't fix; after looking closely at JSPWIKI-1147.
it is unrelated to the cookie noted before and it's a different bug on its own..
---
juanpablo-santos merged pull request #46:
URL: https://github.com/apache/jspwiki/pull/46
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
juanpablo-santos merged pull request #36:
URL: https://github.com/apache/jspwiki/pull/36
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
takalat commented on pull request #44:
URL: https://github.com/apache/jspwiki/pull/44#issuecomment-796656255
> @takalat since you seem to know finnish :-) one quick contribution that
could be made, and would be greatly appreciated, is to complete the associated
[i18n fi files](https://jspw
juanpablo-santos commented on pull request #44:
URL: https://github.com/apache/jspwiki/pull/44#issuecomment-796696284
Hi @takalat,
you could use f.ex.
[JSPWIKI-778](https://issues.apache.org/jira/projects/JSPWIKI/issues/JSPWIKI-778);
it was opened sometime ago, and it is asking for
arturobernalg opened a new pull request #47:
URL: https://github.com/apache/jspwiki/pull/47
Replace construction of FileInputStream and FileOutputStream objects with
Files NIO APIs.
Please note, that the java.nio API does not throw a FileNotFoundException
anymore, instead it throws a No
1 - 100 of 695 matches
Mail list logo
