juanpablo-santos commented on a change in pull request #15: URL: https://github.com/apache/jspwiki/pull/15#discussion_r548192748
########## File path: .github/dependabot.yml ########## @@ -0,0 +1,25 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +version: 2 +updates: Review comment: Just not specifying a `docker` `package-ecosystem` section should be enough. What I tried to mean on my previous comment is that we could also check for it, but it is not necessary, as the `Dockerfile` is currently fixed for Apache Tomcat 9.0 versions. As for the ignored dependencies/versions, they should go under the `maven` `package ecosystem`, the `github-actions` one should be deleted, as we're not currently using them. Somehow I missed this on the initial review.. thx, juan pablo ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
